From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.0.0.0/16 X-Spam-Status: No, score=-2.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, SPF_SOFTFAIL shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XQA4N-0007sV-QV for mharc-bug-gnulib@gnu.org; Sat, 06 Sep 2014 03:05:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQA4L-0007s3-LL for bug-gnulib@gnu.org; Sat, 06 Sep 2014 03:05:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQA4K-0000n5-9P for bug-gnulib@gnu.org; Sat, 06 Sep 2014 03:05:57 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:38238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQA4J-0000mv-Vz for bug-gnulib@gnu.org; Sat, 06 Sep 2014 03:05:56 -0400 Received: by mail-wi0-f169.google.com with SMTP id n3so487172wiv.4 for ; Sat, 06 Sep 2014 00:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=yeEq+zwJmrYyEw+/30Cwu3VKVMg1F55QvnSym9RndSU=; b=KyNhPnLS66H/VrTsD8gPVvwih+znuDuklYClGSmBYJGdR69K+Bw5tN0ccMAaFS/Vby mA2RX4ur3i/sBClovhVRyU/pgwHKmn2giIxlr9zbsOSja2R9PGvdq2tg/tUPu5DWMnz3 uHXsAqGz13GW9L8aZQdWOZ8vHBXz+k6kd5G2Q7GqLBCu7ps/P+jb4FXkM8ofyoVZsNWi WaYDAu/sQ8WKV7khX0vlDGRknTxAClwMYyYJO4KwgxzwpOABkHXjr+RIMOfL4aiwFcVm RSNsflIPr3a/ufOBDXpyeIrRGTUyA4rPNztoM6M1TKPocmql6ts138UBUOgvZ4jubOkd 5uRQ== MIME-Version: 1.0 X-Received: by 10.180.37.108 with SMTP id x12mr8684522wij.16.1409987155008; Sat, 06 Sep 2014 00:05:55 -0700 (PDT) Received: by 10.194.246.36 with HTTP; Sat, 6 Sep 2014 00:05:54 -0700 (PDT) In-Reply-To: <5409DBEA.8010006@cs.ucla.edu> References: <5409DBEA.8010006@cs.ucla.edu> Date: Sat, 6 Sep 2014 02:05:54 -0500 Message-ID: Subject: Re: compile warnings when including avltree-list and gcc-warnings is enabled From: Dylan Cali To: Paul Eggert Content-Type: multipart/mixed; boundary=e89a8f502e16833eee0502603748 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::229 Cc: bug-gnulib@gnu.org X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Sep 2014 07:05:58 -0000 --e89a8f502e16833eee0502603748 Content-Type: text/plain; charset=UTF-8 On Fri, Sep 5, 2014 at 10:51 AM, Paul Eggert wrote: > Thanks, it looks like some declarations are missing in the corresponding .h > file, or are missing attributes that they should have. Is that something > you could write a patch for? Hi Paul, Attached is a patch for the attribute and declaration warnings. After fixing those the next warning that popped up is: lib/gl_avltree_list.c: In function 'gl_avltree_list_check_invariants': lib/gl_avltree_list.c:66:5: error: statement with no effect [-Werror=unused-value] check_invariants (list->root, NULL); ^ I'm not sure how to proceed with this one. It seems gcc is just confused (the statement definitely has an effect as that function aborts if the checks fail). Would it be appropriate to add a pragma to ignore the warning for that function? Thanks, Dylan --e89a8f502e16833eee0502603748 Content-Type: text/x-patch; charset=US-ASCII; name="fix-attr-declaration-warnings.patch" Content-Disposition: attachment; filename="fix-attr-declaration-warnings.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hzqm0eyg0 RnJvbSBiNDdkNzgwYjkwM2I0ZWExZmNjNDQyMWM2MDVkYzJjMDk3OGM0YzNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEeWxhbiBDYWxpIDxjYWxpZDE5ODRAZ21haWwuY29tPgpEYXRl OiBTYXQsIDYgU2VwIDIwMTQgMDE6NTI6MzEgLTA1MDAKU3ViamVjdDogW1BBVENIXSBidWlsZDog Zml4IGF0dHJpYnV0ZSBhbmQgZGVjbGFyYXRpb24gd2FybmluZ3MKCiogdGVzdHMvdGVzdC1hdmx0 cmVlX2xpc3QuYzogUmVtb3ZlIGdsX2F2bHRyZWVfbGlzdF9jaGVja19pbnZhcmlhbnRzCmRlY2xh cmF0aW9uCiogbGliL2dsX2F2bHRyZWVfbGlzdC5oOiBBZGQgZ2xfYXZsdHJlZV9saXN0X2NoZWNr X2ludmFyaWFudHMKZGVjbGFyYXRpb24gZnJvbSB0ZXN0LWF2bHRyZWVfbGlzdC5jCiogbGliL2ds X2F2bHRyZWVfbGlzdC5jOiAoY2hlY2tfaW52YXJpYW50cyk6IEFkZCBwdXJlIGF0dHJpYnV0ZQoo Z2xfYXZsdHJlZV9saXN0X2NoZWNrX2ludmFyaWFudHMpOiBBZGQgY29uc3QgYXR0cmlidXRlCiog bGliL2dsX2FueXRyZWVfbGlzdDIuaDogQWRkIHB1cmUgYXR0cmlidXRlIHRvIChnbF90cmVlX25v ZGVfdmFsdWUpLAooZ2xfdHJlZV9uZXh0X25vZGUpLCAoZ2xfdHJlZV9wcmV2aW91c19ub2RlKSwg KG5vZGVfYXQpLAooZ2xfdHJlZV9nZXRfYXQpCi0tLQogbGliL2dsX2FueXRyZWVfbGlzdDIuaCAg ICB8IDEwICsrKysrLS0tLS0KIGxpYi9nbF9hdmx0cmVlX2xpc3QuYyAgICAgfCAgNCArKy0tCiBs aWIvZ2xfYXZsdHJlZV9saXN0LmggICAgIHwgIDEgKwogdGVzdHMvdGVzdC1hdmx0cmVlX2xpc3Qu YyB8ICAyIC0tCiA0IGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saWIvZ2xfYW55dHJlZV9saXN0Mi5oIGIvbGliL2dsX2FueXRyZWVf bGlzdDIuaAppbmRleCA3MGU1OWE1Li4wNWZkZTE1IDEwMDY0NAotLS0gYS9saWIvZ2xfYW55dHJl ZV9saXN0Mi5oCisrKyBiL2xpYi9nbF9hbnl0cmVlX2xpc3QyLmgKQEAgLTU5LDcgKzU5LDcgQEAg Z2xfdHJlZV9zaXplIChnbF9saXN0X3QgbGlzdCkKICAgcmV0dXJuIChsaXN0LT5yb290ICE9IE5V TEwgPyBsaXN0LT5yb290LT5icmFuY2hfc2l6ZSA6IDApOwogfQogCi1zdGF0aWMgY29uc3Qgdm9p ZCAqCitzdGF0aWMgY29uc3Qgdm9pZCAqIF9HTF9BVFRSSUJVVEVfUFVSRQogZ2xfdHJlZV9ub2Rl X3ZhbHVlIChnbF9saXN0X3QgbGlzdCwgZ2xfbGlzdF9ub2RlX3Qgbm9kZSkKIHsKICAgcmV0dXJu IG5vZGUtPnZhbHVlOwpAQCAtMTAwLDcgKzEwMCw3IEBAIGdsX3RyZWVfbm9kZV9ueF9zZXRfdmFs dWUgKGdsX2xpc3RfdCBsaXN0LCBnbF9saXN0X25vZGVfdCBub2RlLCBjb25zdCB2b2lkICplbHQp CiAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgZ2xfbGlzdF9ub2RlX3QKK3N0YXRpYyBnbF9saXN0 X25vZGVfdCBfR0xfQVRUUklCVVRFX1BVUkUKIGdsX3RyZWVfbmV4dF9ub2RlIChnbF9saXN0X3Qg bGlzdCwgZ2xfbGlzdF9ub2RlX3Qgbm9kZSkKIHsKICAgaWYgKG5vZGUtPnJpZ2h0ICE9IE5VTEwp CkBAIC0xMTgsNyArMTE4LDcgQEAgZ2xfdHJlZV9uZXh0X25vZGUgKGdsX2xpc3RfdCBsaXN0LCBn bF9saXN0X25vZGVfdCBub2RlKQogICByZXR1cm4gbm9kZTsKIH0KIAotc3RhdGljIGdsX2xpc3Rf bm9kZV90CitzdGF0aWMgZ2xfbGlzdF9ub2RlX3QgX0dMX0FUVFJJQlVURV9QVVJFCiBnbF90cmVl X3ByZXZpb3VzX25vZGUgKGdsX2xpc3RfdCBsaXN0LCBnbF9saXN0X25vZGVfdCBub2RlKQogewog ICBpZiAobm9kZS0+bGVmdCAhPSBOVUxMKQpAQCAtMTM3LDcgKzEzNyw3IEBAIGdsX3RyZWVfcHJl dmlvdXNfbm9kZSAoZ2xfbGlzdF90IGxpc3QsIGdsX2xpc3Rfbm9kZV90IG5vZGUpCiB9CiAKIC8q IFJldHVybiB0aGUgbm9kZSBhdCB0aGUgZ2l2ZW4gcG9zaXRpb24gPCBnbF90cmVlX3NpemUgKGxp c3QpLiAgKi8KLXN0YXRpYyBnbF9saXN0X25vZGVfdAorc3RhdGljIGdsX2xpc3Rfbm9kZV90IF9H TF9BVFRSSUJVVEVfUFVSRQogbm9kZV9hdCAoZ2xfbGlzdF9ub2RlX3Qgcm9vdCwgc2l6ZV90IHBv c2l0aW9uKQogewogICAvKiBIZXJlIHdlIGtub3cgdGhhdCByb290ICE9IE5VTEwuICAqLwpAQCAt MTYyLDcgKzE2Miw3IEBAIG5vZGVfYXQgKGdsX2xpc3Rfbm9kZV90IHJvb3QsIHNpemVfdCBwb3Np dGlvbikKICAgcmV0dXJuIG5vZGU7CiB9CiAKLXN0YXRpYyBjb25zdCB2b2lkICoKK3N0YXRpYyBj b25zdCB2b2lkICogX0dMX0FUVFJJQlVURV9QVVJFCiBnbF90cmVlX2dldF9hdCAoZ2xfbGlzdF90 IGxpc3QsIHNpemVfdCBwb3NpdGlvbikKIHsKICAgZ2xfbGlzdF9ub2RlX3Qgbm9kZSA9IGxpc3Qt PnJvb3Q7CmRpZmYgLS1naXQgYS9saWIvZ2xfYXZsdHJlZV9saXN0LmMgYi9saWIvZ2xfYXZsdHJl ZV9saXN0LmMKaW5kZXggMWFmZTVjYS4uMzFlZDMzNCAxMDA2NDQKLS0tIGEvbGliL2dsX2F2bHRy ZWVfbGlzdC5jCisrKyBiL2xpYi9nbF9hdmx0cmVlX2xpc3QuYwpAQCAtMzcsNyArMzcsNyBAQAog I2luY2x1ZGUgImdsX2FueXRyZWVfbGlzdDIuaCIKIAogLyogRm9yIGRlYnVnZ2luZy4gICovCi1z dGF0aWMgdW5zaWduZWQgaW50CitzdGF0aWMgdW5zaWduZWQgaW50IF9HTF9BVFRSSUJVVEVfUFVS RQogY2hlY2tfaW52YXJpYW50cyAoZ2xfbGlzdF9ub2RlX3Qgbm9kZSwgZ2xfbGlzdF9ub2RlX3Qg cGFyZW50KQogewogICB1bnNpZ25lZCBpbnQgbGVmdF9oZWlnaHQgPQpAQCAtNTksNyArNTksNyBA QCBjaGVja19pbnZhcmlhbnRzIChnbF9saXN0X25vZGVfdCBub2RlLCBnbF9saXN0X25vZGVfdCBw YXJlbnQpCiAKICAgcmV0dXJuIDEgKyAobGVmdF9oZWlnaHQgPiByaWdodF9oZWlnaHQgPyBsZWZ0 X2hlaWdodCA6IHJpZ2h0X2hlaWdodCk7CiB9Ci12b2lkCit2b2lkIF9HTF9BVFRSSUJVVEVfQ09O U1QKIGdsX2F2bHRyZWVfbGlzdF9jaGVja19pbnZhcmlhbnRzIChnbF9saXN0X3QgbGlzdCkKIHsK ICAgaWYgKGxpc3QtPnJvb3QgIT0gTlVMTCkKZGlmZiAtLWdpdCBhL2xpYi9nbF9hdmx0cmVlX2xp c3QuaCBiL2xpYi9nbF9hdmx0cmVlX2xpc3QuaAppbmRleCA3ZjA5ZmYzLi5lODMwMGYxIDEwMDY0 NAotLS0gYS9saWIvZ2xfYXZsdHJlZV9saXN0LmgKKysrIGIvbGliL2dsX2F2bHRyZWVfbGlzdC5o CkBAIC0yNCw2ICsyNCw3IEBACiBleHRlcm4gIkMiIHsKICNlbmRpZgogCitleHRlcm4gdm9pZCBn bF9hdmx0cmVlX2xpc3RfY2hlY2tfaW52YXJpYW50cyAoZ2xfbGlzdF90IGxpc3QpOwogZXh0ZXJu IGNvbnN0IHN0cnVjdCBnbF9saXN0X2ltcGxlbWVudGF0aW9uIGdsX2F2bHRyZWVfbGlzdF9pbXBs ZW1lbnRhdGlvbjsKICNkZWZpbmUgR0xfQVZMVFJFRV9MSVNUICZnbF9hdmx0cmVlX2xpc3RfaW1w bGVtZW50YXRpb24KIApkaWZmIC0tZ2l0IGEvdGVzdHMvdGVzdC1hdmx0cmVlX2xpc3QuYyBiL3Rl c3RzL3Rlc3QtYXZsdHJlZV9saXN0LmMKaW5kZXggMWMwMzMxYS4uYzg3N2MwOSAxMDA2NDQKLS0t IGEvdGVzdHMvdGVzdC1hdmx0cmVlX2xpc3QuYworKysgYi90ZXN0cy90ZXN0LWF2bHRyZWVfbGlz dC5jCkBAIC0yNSw4ICsyNSw2IEBACiAjaW5jbHVkZSAicHJvZ25hbWUuaCIKICNpbmNsdWRlICJt YWNyb3MuaCIKIAotZXh0ZXJuIHZvaWQgZ2xfYXZsdHJlZV9saXN0X2NoZWNrX2ludmFyaWFudHMg KGdsX2xpc3RfdCBsaXN0KTsKLQogc3RhdGljIGNvbnN0IGNoYXIgKm9iamVjdHNbMTVdID0KICAg ewogICAgICJhIiwgImIiLCAiYyIsICJkIiwgImUiLCAiZiIsICJnIiwgImgiLCAiaSIsICJqIiwg ImsiLCAibCIsICJtIiwgIm4iLCAibyIKLS0gCjIuMS4wCgo= --e89a8f502e16833eee0502603748--