From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 37F821F4B4 for ; Sun, 20 Dec 2020 14:50:25 +0000 (UTC) Received: from localhost ([::1]:37952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr02S-0001Qp-1W for normalperson@yhbt.net; Sun, 20 Dec 2020 09:50:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr02F-0001PN-Se; Sun, 20 Dec 2020 09:50:11 -0500 Received: from mailbackend.panix.com ([166.84.1.89]:17844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr02D-0004Nh-0k; Sun, 20 Dec 2020 09:50:11 -0500 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4CzQW34MLYzQ84; Sun, 20 Dec 2020 09:50:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1608475807; bh=t78d01LKQOyR9SZKI0c5PKb9/bxOLdNZFWHok/cuKtw=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=pUALRnX9LJtzPtrsMLOhyhVHipt4NaoCah7bD2RvkwMeqwwfxm6hQ2xt5Fa7KmuEn mcmIcqcbX3w/h7+DEXison4YwJGwndCaFdkrXo3PKlNPqF83E2aCnPvgx4WK9tP8T+ 4H7skq8QSY8xKsfQ9giJiDL0xRAQwdGSX8Yq1LrU= Received: by mail-ed1-f43.google.com with SMTP id b73so7133334edf.13; Sun, 20 Dec 2020 06:50:07 -0800 (PST) X-Gm-Message-State: AOAM531g7W5fLQK+F+tEcG3cFu4WSqt2sZLNLQzUqSvTJ5C7fH0a0DIK tneBxApMLCTD7f6DrbzrzYQmtpHsn3lR1RaflgE= X-Google-Smtp-Source: ABdhPJwUD3tc3US2mlMN+hP4yimc8QM3t33xfHPe9Pad1Ft9kQfziMi03u0jhQNdVJfdmP14cTS3hx+fZv2CeONhy6E= X-Received: by 2002:a05:6402:312c:: with SMTP id dd12mr12651814edb.327.1608475806741; Sun, 20 Dec 2020 06:50:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Zack Weinberg Date: Sun, 20 Dec 2020 09:49:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Request to revert the C version change To: Ross Burton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=166.84.1.89; envelope-from=zackw@panix.com; helo=mailbackend.panix.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Autoconf , Gnulib bugs Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Wed, Dec 16, 2020 at 2:02 PM Zack Weinberg wrote: > On Wed, Dec 16, 2020 at 1:52 PM Ross Burton wrote: > > | checking for gcc option to enable C11 features... none needed > > | ../bison-3.7.4/configure: line 6187: syntax error near unexpected > > token `ac_cv_prog_cc_stdc=3D$ac_cv_prog_cc_c89' > > | ../bison-3.7.4/configure: line 6187: ` > > ac_cv_prog_cc_stdc=3D$ac_cv_prog_cc_c89' > > > > gettext failed in the same manner. > > > > I can bisect and identify where it broke tomorrow. > > Thanks. This is definitely not a failure I saw in my testing, but it > smells like another typo in the shell code, so hopefully not hard to > fix. The problem appears to be that gnulib's std-gnu11.m4 replaces *most* of the definition of AC_PROG_CC, in a way that conflicts with the refactor. I'm looking for a way to avoid the conflict within autoconf proper, but a workaround is to apply this patch to std-gnu11.m4: $ diff -u m4/std-gnu11.m4{~,} --- m4/std-gnu11.m4~ 2020-08-30 11:27:01.000000000 -0400 +++ m4/std-gnu11.m4 2020-12-20 09:43:13.001477099 -0500 @@ -27,6 +27,8 @@ # Fran=C3=A7ois Pinard, Karl Berry, Richard Pixley, Ian Lance Taylor, # Roland McGrath, Noah Friedman, david d zuhn, and many others. +m4_version_prereq([2.70], [], [ + # AC_PROG_CC([COMPILER ...]) # -------------------------- @@ -822,3 +824,5 @@ dnl with extended modes being tried first. [[-std=3Dgnu++11 -std=3Dc++11 -std=3Dgnu++0x -std=3Dc++0x -qlanglvl=3Dextended0x -AA]], [$1], [$2])[]dnl ])# _AC_PROG_CXX_CXX11 + +])# m4_version_prereq I recommend this patch be applied in Gnulib proper. It may be wise to go through all of gnulib's m4 files and see if any others need the same treatment. (Any m4 file that backports code from the development series leading up to 2.70 is a candidate.) zw