From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0E3871F4B4 for ; Sun, 27 Sep 2020 14:14:46 +0000 (UTC) Received: from localhost ([::1]:39190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMXRs-0005J0-Vj for normalperson@yhbt.net; Sun, 27 Sep 2020 10:14:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMXRp-0005IZ-TZ; Sun, 27 Sep 2020 10:14:41 -0400 Received: from mailbackend.panix.com ([166.84.1.89]:38311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMXRo-0002GU-7H; Sun, 27 Sep 2020 10:14:41 -0400 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4Bznhv0VYfz1YvM; Sun, 27 Sep 2020 10:14:39 -0400 (EDT) Received: by mail-ej1-f45.google.com with SMTP id gr14so4830816ejb.1; Sun, 27 Sep 2020 07:14:39 -0700 (PDT) X-Gm-Message-State: AOAM530Nsu907PAZMU5dCUQmqAaZWLwOhn77CAouMJOYPMyZXcrfxe3L 86Kx92cEfJanrTC5AFeBZuUeCmLJtfwyljnl7ac= X-Google-Smtp-Source: ABdhPJxkVtCDygDetgGW1LcaoRAT/r3ipms6eSH/dpYJBlEjE9M0dVahuZTqXCI01N/xZc2nEEVoIp21ssFIqr8tjJk= X-Received: by 2002:a17:906:1c13:: with SMTP id k19mr11292592ejg.384.1601216078132; Sun, 27 Sep 2020 07:14:38 -0700 (PDT) MIME-Version: 1.0 References: <20200927102822.GD15735@mintstar> In-Reply-To: <20200927102822.GD15735@mintstar> From: Zack Weinberg Date: Sun, 27 Sep 2020 10:14:27 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Results from running autoupdate on gnulib m4 files To: Gavin Smith Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=166.84.1.89; envelope-from=zackw@panix.com; helo=mailbackend.panix.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 10:14:39 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Autoconf , Gnulib bugs Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Sun, Sep 27, 2020 at 6:29 AM Gavin Smith wrote: > Because of the upcoming autoconf 2.70 release gives more warnings, I > checked the other files in gnulib in the m4 directory with > > autoupdate -v *.m4 2>&1 | tee log Thanks for doing this. I was getting set up to do it myself, but I got hung up on an unrelated problem (the version of "gettext" in Debian is severely outdated and this makes it hard to run the gnulib test suite). The diff produced by autoupdate is mostly not usable as is. In fact, it looks to me more like a todo list for bugs and missing features in autoupdate itself :-/ For instance, replacing `AC_REQUIRE([AC_HEADER_STDC])` with `AC_REQUIRE([m4_warn([obsolete], ...])` is Just Plain Wrong, as is replacing `pushdef([AC_CHECKING], [:])` with `pushdef([AS_MESSAGE([checking ...])],[:])`. However, the change to m4/gethostname.m4 looks correct. > * Redefinition of AC_CHECKING in several files to silence AC_CHECK_PROG This was discussed previously at https://lists.gnu.org/archive/html/bug-gnulib/2020-03/msg00032.html . It remains my opinion that the correct fix is to convert all of these to AC_CACHE_CHECK and not try to hide any checks from the person running configure. zw