From: Jeffrey Walton <noloader@gmail.com>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: test-math.c:89:3: runtime error: division by zero
Date: Sun, 29 Mar 2020 19:30:22 -0400 [thread overview]
Message-ID: <CAH8yC8n77NWbBqsxjXAHe-7BEBz5XYZyBHK=2k64mdR82UH6nw@mail.gmail.com> (raw)
In-Reply-To: <CAH8yC8m=1O-ak00v7QewcHus+qHoqjp2RPN5gHxdRiNjOb_=NQ@mail.gmail.com>
On Sun, Mar 29, 2020 at 7:21 PM Jeffrey Walton <noloader@gmail.com> wrote:
>
> On Sun, Mar 29, 2020 at 5:59 PM Bruno Haible <bruno@clisp.org> wrote:
> >
> > Jeffrey Walton wrote:
> > > Let's see what the GCC folks recommend: "GCC and division by 0 under
> > > sanitizers", https://gcc.gnu.org/pipermail/gcc-help/2020-March/138746.html.
> >
> > The way I interpret their answer
> > https://gcc.gnu.org/pipermail/gcc-help/2020-March/138747.html
> > is:
> > 1) You need to distinguish integer division by zero and floating-point
> > division by zero.
> > 2) For floating-point division by zero GCC warns but should not warn.
> > You should enter a bug report about this.
> > 3) The undefined-behaviour sanitizer should report integer division by zero
> > but not floating-point division by zero ("as it can be a legitimate way
> > of obtaining infinities and NaNs").
> >
> > In the gnulib code, test-math.c:89, we clearly have a floating-point
> > division by zero.
>
> Yeah, GCC looks partially clean. It is not producing a sanitizer
> finding, so I guess no blood, no foul.
>
> Clang is a problem: https://bugs.llvm.org/show_bug.cgi?id=45352.
Here's a workaround, but I think it looks like fido's ass:
$ cat test.c
#include <float.h>
#include <math.h>
#if defined(__clang__)
# define CLANG_NO_DIV_BY_ZERO
__attribute__((no_sanitize("float-divide-by-zero")))
#else
# define CLANG_NO_DIV_BY_ZERO
#endif
CLANG_NO_DIV_BY_ZERO
int main(void)
{
return INFINITY == 1.0f / 0.0f ? 0 : 1;
}
$ clang -fsanitize=undefined test.c -o test.exe
$ ./test.exe
$ clang --version
clang version 6.0.0-1ubuntu2
Would you be willing to hide a macro like CLANG_NO_DIV_BY_ZERO in a
header somewhere so it can be used in tests like test-math.h?
Jeff
next prev parent reply other threads:[~2020-03-29 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 13:32 test-math.c:89:3: runtime error: division by zero Jeffrey Walton
2020-03-29 16:24 ` Bruno Haible
2020-03-29 21:09 ` Jeffrey Walton
2020-03-29 21:59 ` Bruno Haible
2020-03-29 23:21 ` Jeffrey Walton
2020-03-29 23:30 ` Jeffrey Walton [this message]
2020-03-29 23:35 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH8yC8n77NWbBqsxjXAHe-7BEBz5XYZyBHK=2k64mdR82UH6nw@mail.gmail.com' \
--to=noloader@gmail.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).