From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6AD591F55B for ; Sat, 30 May 2020 12:26:44 +0000 (UTC) Received: from localhost ([::1]:44032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf0ZX-0006fR-6W for normalperson@yhbt.net; Sat, 30 May 2020 08:26:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf0ZN-0006Uk-Bh for bug-gnulib@gnu.org; Sat, 30 May 2020 08:26:33 -0400 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]:37997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf0ZM-0002i2-8Q for bug-gnulib@gnu.org; Sat, 30 May 2020 08:26:32 -0400 Received: by mail-il1-x142.google.com with SMTP id q18so5118944ilm.5 for ; Sat, 30 May 2020 05:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=aNRC89A/yuqVHxsljMIcPCr0CgZP4AKIPpGHz0XROcQ=; b=OX2sVcsWEZNs2pWthXgG3zyzEnlil+EkACZTSG3feDYwBACiScfhugZTntSimS/lju sDCv4XK7V1WVRyuyqH8kF0y1NgheNHu0gNBHETatPHkW58dLaa1k4J+4Z1gEjYQB56UN yRj6sJ7VnJKUJiQXSLzhgxvznLBi7DoylWPb3v6l8EsNiPkoCpWWhy9abODGQzYEpBcQ SMpb+vkRz10Tl5WQY45H5OasmmTpVDKjkcSUqUFbEAnO+KA1Bko3D80e22XhvsuTGYxx hAFMt7mcJX4nJxR854qQNDnFtoqhalfTeVWeHfffbelIaJl4RjvqUGNWdDyVDVXRJ+WI e1vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=aNRC89A/yuqVHxsljMIcPCr0CgZP4AKIPpGHz0XROcQ=; b=sVbhQs3187hdqN7WQPlZJKWsr6W0clrjBviB0ZC8enTLDTI09XAVRFFq4DDujp0mT0 3nzMGZ79k68Qax+msXPt1LCpFGHtqbwDSr7vcplGZ3BogcUt/z6oA7LEsrPxCtUszEWx y39WGdTKH6dYascJgOWMNiis/2+Jv+8OkhBE+Od1HIw1d+4MpPT9dXqZbenBRciwvSOr tloIOzNkv0JdEqxleuxE2j6y3LKsgTQ54Jnsx41wxcw4DeXHBbfAakERgz3Kd7z5uY/F 8AWIWTIpCe1ddSguwHHXTl62IJqKH8CszS+3MGPsoIbjoqkx8yl1tYCYA/4wJQCMJZFu ZwYg== X-Gm-Message-State: AOAM5301ZuGXy3WWHcDvTwhBAldwwUOddbll1xEH9EmNLK/cCxKw7yR1 iZMvDitBXfeEaAuF8pjSQeBRQ4ddhbq396fhKHiwEaCu+tM= X-Google-Smtp-Source: ABdhPJyGPdrUODjkA+6yGvoUIvL7lblbq79COftOzjQx/ih3UaESNjYgWzEczjhkanMmqI7duwzQr6byQnMgd68C7ZA= X-Received: by 2002:a92:d449:: with SMTP id r9mr12462432ilm.166.1590841591126; Sat, 30 May 2020 05:26:31 -0700 (PDT) MIME-Version: 1.0 References: <8420710.z7x3erh4Ic@omega> In-Reply-To: <8420710.z7x3erh4Ic@omega> From: Jeffrey Walton Date: Sat, 30 May 2020 08:26:08 -0400 Message-ID: Subject: Re: crypto/gc-random: Fix link error on MSVC To: Bruno Haible Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::142; envelope-from=noloader@gmail.com; helo=mail-il1-x142.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: noloader@gmail.com Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Sat, May 30, 2020 at 8:17 AM Bruno Haible wrote: > > A testdir for module 'crypto/gc-random' produces a link error > on MSVC 14: > > libgnu.a(gc-gnulib.obj) : error LNK2019: unresolved external symbol __imp_CryptAcquireContextA referenced in function gc_init > libgnu.a(gc-gnulib.obj) : error LNK2019: unresolved external symbol __imp_CryptReleaseContext referenced in function gc_init > libgnu.a(gc-gnulib.obj) : error LNK2019: unresolved external symbol __imp_CryptGenRandom referenced in function randomize > test-gc.exe : fatal error LNK1120: 3 unresolved externals > > This patch fixes it. > > > 2020-05-30 Bruno Haible > > crypto/gc-random: Fix link error on MSVC. > * m4/gc-random.m4 (gl_GC_RANDOM): Set LIB_GC_RANDOM. > * modules/crypto/gc-random (Link): New section. > * modules/crypto/gc-tests (Makefile.am): Link test-gc against > $(LIB_GC_RANDOM). > > diff --git a/m4/gc-random.m4 b/m4/gc-random.m4 > index 09483da..de9c1bb 100644 > --- a/m4/gc-random.m4 > +++ b/m4/gc-random.m4 > @@ -1,4 +1,4 @@ > -# gc-random.m4 serial 6 > +# gc-random.m4 serial 7 > dnl Copyright (C) 2005-2020 Free Software Foundation, Inc. > dnl This file is free software; the Free Software Foundation > dnl gives unlimited permission to copy and/or distribute it, > @@ -9,7 +9,7 @@ AC_DEFUN([gl_GC_RANDOM], > # Devices with randomness. > # FIXME: Are these the best defaults? > > - AC_REQUIRE([AC_CANONICAL_HOST])dnl > + AC_REQUIRE([AC_CANONICAL_HOST]) > > case "$host_os" in > *openbsd* | *mirbsd*) > @@ -84,4 +84,12 @@ AC_DEFUN([gl_GC_RANDOM], > [defined to the name of the pseudo random device]) > AC_DEFINE_UNQUOTED([NAME_OF_NONCE_DEVICE], ["$NAME_OF_NONCE_DEVICE"], > [defined to the name of the unpredictable nonce device]) > + > + case $host_os in > + mingw*) > + LIB_GC_RANDOM='-ladvapi32' ;; > + *) > + LIB_GC_RANDOM= ;; > + esac > + AC_SUBST([LIB_GC_RANDOM]) > ]) > diff --git a/modules/crypto/gc-random b/modules/crypto/gc-random > index 2f17871..2ffec7c 100644 > --- a/modules/crypto/gc-random > +++ b/modules/crypto/gc-random > @@ -16,6 +16,9 @@ Makefile.am: > Include: > "gc.h" > > +Link: > +$(LIB_GC_RANDOM) > + > License: > LGPLv2+ > > diff --git a/modules/crypto/gc-tests b/modules/crypto/gc-tests > index 7b153d1..f3da986 100644 > --- a/modules/crypto/gc-tests > +++ b/modules/crypto/gc-tests > @@ -8,4 +8,4 @@ configure.ac: > Makefile.am: > TESTS += test-gc > check_PROGRAMS += test-gc > -test_gc_LDADD = $(LDADD) @LIB_CRYPTO@ > +test_gc_LDADD = $(LDADD) @LIB_CRYPTO@ $(LIB_GC_RANDOM) On modern Windows systems you should use BCryptGenRandom for the material. CryptGenRandom is deprecated. Also see https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom. Jeff