From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3AA721F5AE for ; Fri, 10 Jul 2020 21:38:10 +0000 (UTC) Received: from localhost ([::1]:42346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ju0if-0003u0-1F for normalperson@yhbt.net; Fri, 10 Jul 2020 17:38:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ju0iZ-0003tj-Vi; Fri, 10 Jul 2020 17:38:04 -0400 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]:38948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ju0iX-0004Sp-H7; Fri, 10 Jul 2020 17:38:03 -0400 Received: by mail-il1-x142.google.com with SMTP id k6so6307281ili.6; Fri, 10 Jul 2020 14:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:content-transfer-encoding; bh=fYZXwJPvkv5An12ymvCLyenR4DxloewseN1vTss1wCc=; b=PgFR+hDfA54iexreSUveJlXmC5EpOlIYfcHRzhrWJGzmoBfOeuCxwppZanrNrRxaor +G/MBkQsKxJtyzVryFkwrfZ8UnMTiviqvAhrNEVKcHwq/szviV5IOzV2pueyqVPtA3Cx YV1GWy5TjvniqwuOL7lsLG67Yphhl0G2qr/cC1QYhwW8jDHaToyXapKGEZB2qdEAowhh vwrVx71ZH9JU07FkOxadQ4byns8JCJvNYAYvuaPGOHWXtebDYyGwqSRP/jkvZGzEJZQl 7Urp0bS4S0CIMkENL7BbsF1/T7ZWJt5//RnUi8/B7KG+d/Vm9l2x5edubADLrB9/X121 o06g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:content-transfer-encoding; bh=fYZXwJPvkv5An12ymvCLyenR4DxloewseN1vTss1wCc=; b=ItWgDMUrLj0SEawDIszemIm+nBkR0RYGi8ofakcmGjoztZghbG7hV99cEH3cTm7Tqm x0IzDe8u4XhTZcH3b5Hj3Z0xkGGwqKpjol3cuzLHbBddL9IJcEcS04NhG7Q+vxtNuR2T w3TO/+99wmPbzrx7y7R2zaeqoJx9NjKV9/jB4b2A99fZksUF6qKL4LrnssvMUMqd7Qjh ktw85jtZFxoELR4lSI1Ycy46btYf5UT60yJvuOiAI9NiSEUe770q9rHhnXxxTB9D2NoB 1+6upHwR9wxjCKLlbS3Ysj8rtEDSFUcJrMmTGW25+fPgp0AAaorA1BpQoExQyTUPz7AY ApnQ== X-Gm-Message-State: AOAM531pkWfYjjOmK3J0j25rxwRVWKQV0dtnj6kmqVPLbb5Mmyqv4Lx7 +AKvUAsjzCa0y3WxvIuQ9h0BnVLTbCMadvorZmcXRw== X-Google-Smtp-Source: ABdhPJxAgRh3P4L6jln0e4j4s9ZqiWQuD0iM4wWSplqxKorYVM7fd3ih+l6lrRnUOZDQlO4lKjiqweS8CXMhRZ7aoSI= X-Received: by 2002:a92:d181:: with SMTP id z1mr54162960ilz.41.1594417078976; Fri, 10 Jul 2020 14:37:58 -0700 (PDT) MIME-Version: 1.0 References: <77400f8a-59ca-6d02-e5b1-e01ba0619237@draigBrady.com> <4aa67590-a0c3-603d-d2b1-f0751a28df29@cs.ucla.edu> <3a074086-47f7-638f-50a8-cd7ceb46a11a@draigBrady.com> <0f92f576-bf1c-e889-3e4a-a128455b5684@cs.ucla.edu> <9d8897dc-b415-afce-bc34-b9f934b8f905@cs.ucla.edu> In-Reply-To: From: Jeffrey Walton Date: Fri, 10 Jul 2020 17:37:48 -0400 Message-ID: Subject: Re: coreutils and GCC -fanalyzer To: bug-gnulib@gnu.org, coreutils@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::142; envelope-from=noloader@gmail.com; helo=mail-il1-x142.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: noloader@gmail.com Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Fri, Jul 10, 2020 at 5:22 PM P=C3=A1draig Brady wrote= : > > On 02/07/2020 01:26, Paul Eggert wrote: > > On 5/23/20 9:08 AM, Paul Eggert wrote: > > > >> So I am thinking of killing two > >> stones by doing the following. > >> > >> 1. Test for -fanalyzer, -Wall, -Wextra. > >> > >> 2. Test for flags not automatically enabled by -fanalyzer, -Wall, -Wex= tra but > >> flags that we want anyway. > >> > >> 3. Test for flags automatically enabled by -fanalyzer, -Wall, -Wextra = that are > >> also flags that we don't want. > > > > I did that in Gnulib by installing the attached patch. This could great= ly > > increase compile times due to the -fanalyzer option, so let's keep an e= ye out > > for that. > > s/could/does/. > compile time has gone from seconds to minutes for coreutils at least. > > I'd be inclined to not enable -fanalyzer by default. > At least not until it matures more. > -fanalyzer didn't find any actual issues in coreutils, > and currently bails on most files (after taking lots of time about it), > as indicated with the -Wanalyzer-too-complex option. Just my 2 cents, but leave analyzer options to testing and QA folks. Make the option available for convenience, but leave it off by default. The testers and QA folks will perform the enhanced testing on occasion, like during a CI build or manually before a release. The remainder of the time, regular users get a regular build. Jeff