From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4839A1F46C for ; Sun, 5 Jan 2020 06:25:16 +0000 (UTC) Received: from localhost ([::1]:39546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inzLe-0004zI-IA for normalperson@yhbt.net; Sun, 05 Jan 2020 01:25:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60636) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inzLY-0004yz-FL for bug-gnulib@gnu.org; Sun, 05 Jan 2020 01:25:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inzLX-0007Uz-88 for bug-gnulib@gnu.org; Sun, 05 Jan 2020 01:25:08 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:44459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inzLX-0007Qe-1J for bug-gnulib@gnu.org; Sun, 05 Jan 2020 01:25:07 -0500 Received: by mail-wr1-f48.google.com with SMTP id q10so7243802wrm.11 for ; Sat, 04 Jan 2020 22:25:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=osCqGIC1lc7iwobOO1EZdd8WlQHMNOAN7MRsdyFCRLE=; b=dmpy6Et+RzOcWiusKyi7zPCiSvgmXuUhbp7x0m4MtJ4ceWLazNtvD/vh0TR8ehehvS cHxCsDkS4Rh45xBhvQu2I0wRz1DslKfxXbUVNKYIrOWjOlvF+D4EkFgd5uICW4wzmQyJ iy1axLqQTN6ERB9uZC4zaEdyWbSR87VOw4n1DT0/K25gbSJzUZfUhnR3YJtH8rOrIlUz Oa+k/213Uft6fVD7m8g0ghYSI6BV8niLbLWlGgrdXMbKtSjn+MNK5+YQBF46sNhP7CAw dpR6v59Y97HHGafYb6L2BuTZvg8rJEc8a7+32YU96CCfWHoAF4H6gcr0ZVJacet/KKwj tDNw== X-Gm-Message-State: APjAAAU8r1j+FDhz5keUx+rPGc3U+vBFGfuW+eBhWmjNK04bDyQjhYGP hoAjoIKQNoYdsN8o+Az2mIaXgMmFvW9wbmnUWLHpzMWP X-Google-Smtp-Source: APXvYqxDPD76w92pw/I9SPKc3cnBt2+4gnx45upyFxmjGKRFPKdMHtWlylFHQpJcdF9KgDGVZzFwLTMRPnDRY0pYdQQ= X-Received: by 2002:adf:8b4f:: with SMTP id v15mr68270497wra.231.1578205504823; Sat, 04 Jan 2020 22:25:04 -0800 (PST) MIME-Version: 1.0 From: Jim Meyering Date: Sat, 4 Jan 2020 22:24:53 -0800 Message-ID: Subject: [PATCH] stdlib: avoid canonicalize_file_name contradiction To: "bug-gnulib@gnu.org List" Content-Type: multipart/mixed; boundary="0000000000007f8502059b5e9a93" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.48 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" --0000000000007f8502059b5e9a93 Content-Type: text/plain; charset="UTF-8" I expect to push something like the attached tomorrow: stdlib: avoid canonicalize_file_name contradiction * lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull attribute from its declaration. tests/test-canonicalize-lgpl.c passes null_ptr () to it, which (via this contradiction) would provoke a segfault from GCC 10. See a small reproducer and discussion in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93156 --0000000000007f8502059b5e9a93 Content-Type: application/octet-stream; name="canonicalize_file_name-nonnull-vs-gcc10-segfault.diff" Content-Disposition: attachment; filename="canonicalize_file_name-nonnull-vs-gcc10-segfault.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k50mse3y0 RnJvbSAwZjdjZmJmNWMyYjM0MDNlZmZjNTkxMGY1N2Y0MjBiNThlZDkxMzMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCA0IEphbiAyMDIwIDIyOjIxOjE3IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gc3RkbGliOiBh dm9pZCBjYW5vbmljYWxpemVfZmlsZV9uYW1lIGNvbnRyYWRpY3Rpb24KCiogbGliL3N0ZGxpYi5p bi5oIChjYW5vbmljYWxpemVfZmlsZV9uYW1lKTogUmVtb3ZlIHRoZSBub25udWxsCmF0dHJpYnV0 ZSBmcm9tIGl0cyBkZWNsYXJhdGlvbi4gdGVzdHMvdGVzdC1jYW5vbmljYWxpemUtbGdwbC5jCnBh c3NlcyBudWxsX3B0ciAoKSB0byBpdCwgd2hpY2ggKHZpYSB0aGlzIGNvbnRyYWRpY3Rpb24pIHdv dWxkCnByb3Zva2UgYSBzZWdmYXVsdCBmcm9tIEdDQyAxMC4gU2VlIGEgc21hbGwgcmVwcm9kdWNl ciBhbmQKZGlzY3Vzc2lvbiBpbiBodHRwczovL2djYy5nbnUub3JnL2J1Z3ppbGxhL3Nob3dfYnVn LmNnaT9pZD05MzE1NgotLS0KIENoYW5nZUxvZyAgICAgICB8IDkgKysrKysrKysrCiBsaWIvc3Rk bGliLmluLmggfCA2ICsrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2 ZDllYTllNTIuLjczMGY1MzcyNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAxLTA0ICBKaW0gTWV5ZXJpbmcgIDxtZXllcmluZ0Bm Yi5jb20+CisKKwlzdGRsaWI6IGF2b2lkIGNhbm9uaWNhbGl6ZV9maWxlX25hbWUgY29udHJhZGlj dGlvbgorCSogbGliL3N0ZGxpYi5pbi5oIChjYW5vbmljYWxpemVfZmlsZV9uYW1lKTogUmVtb3Zl IHRoZSBub25udWxsCisJYXR0cmlidXRlIGZyb20gaXRzIGRlY2xhcmF0aW9uLiB0ZXN0cy90ZXN0 LWNhbm9uaWNhbGl6ZS1sZ3BsLmMKKwlwYXNzZXMgbnVsbF9wdHIgKCkgdG8gaXQsIHdoaWNoICh2 aWEgdGhpcyBjb250cmFkaWN0aW9uKSB3b3VsZAorCXByb3Zva2UgYSBzZWdmYXVsdCBmcm9tIEdD QyAxMC4gU2VlIGEgc21hbGwgcmVwcm9kdWNlciBhbmQKKwlkaXNjdXNzaW9uIGluIGh0dHBzOi8v Z2NjLmdudS5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTkzMTU2CisKIDIwMjAtMDEtMDQg IEJydW5vIEhhaWJsZSAgPGJydW5vQGNsaXNwLm9yZz4KCiAJbWJzbnJ0b2MzMnM6IEFkZCB0ZXN0 cy4KZGlmZiAtLWdpdCBhL2xpYi9zdGRsaWIuaW4uaCBiL2xpYi9zdGRsaWIuaW4uaAppbmRleCBl MDg4OTU5YjIuLjkzOGVjMzdiMSAxMDA2NDQKLS0tIGEvbGliL3N0ZGxpYi5pbi5oCisrKyBiL2xp Yi9zdGRsaWIuaW4uaApAQCAtMTkxLDEzICsxOTEsMTEgQEAgX0dMX1dBUk5fT05fVVNFIChjYWxs b2MsICJjYWxsb2MgaXMgbm90IFBPU0lYIGNvbXBsaWFudCBldmVyeXdoZXJlIC0gIgogIyAgaWYg IShkZWZpbmVkIF9fY3BsdXNwbHVzICYmIGRlZmluZWQgR05VTElCX05BTUVTUEFDRSkKICMgICBk ZWZpbmUgY2Fub25pY2FsaXplX2ZpbGVfbmFtZSBycGxfY2Fub25pY2FsaXplX2ZpbGVfbmFtZQog IyAgZW5kaWYKLV9HTF9GVU5DREVDTF9SUEwgKGNhbm9uaWNhbGl6ZV9maWxlX25hbWUsIGNoYXIg KiwgKGNvbnN0IGNoYXIgKm5hbWUpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIF9HTF9BUkdfTk9OTlVMTCAoKDEpKSk7CitfR0xfRlVOQ0RFQ0xfUlBM IChjYW5vbmljYWxpemVfZmlsZV9uYW1lLCBjaGFyICosIChjb25zdCBjaGFyICpuYW1lKSk7CiBf R0xfQ1hYQUxJQVNfUlBMIChjYW5vbmljYWxpemVfZmlsZV9uYW1lLCBjaGFyICosIChjb25zdCBj aGFyICpuYW1lKSk7CiAjIGVsc2UKICMgIGlmICFASEFWRV9DQU5PTklDQUxJWkVfRklMRV9OQU1F QAotX0dMX0ZVTkNERUNMX1NZUyAoY2Fub25pY2FsaXplX2ZpbGVfbmFtZSwgY2hhciAqLCAoY29u c3QgY2hhciAqbmFtZSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgX0dMX0FSR19OT05OVUxMICgoMSkpKTsKK19HTF9GVU5DREVDTF9TWVMgKGNhbm9u aWNhbGl6ZV9maWxlX25hbWUsIGNoYXIgKiwgKGNvbnN0IGNoYXIgKm5hbWUpKTsKICMgIGVuZGlm CiBfR0xfQ1hYQUxJQVNfU1lTIChjYW5vbmljYWxpemVfZmlsZV9uYW1lLCBjaGFyICosIChjb25z dCBjaGFyICpuYW1lKSk7CiAjIGVuZGlmCi0tIAoyLjI0LjAuMzkwLmcwODMzNzhjYzM1Cgo= --0000000000007f8502059b5e9a93--