From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7DAF51F463 for ; Fri, 13 Dec 2019 17:53:22 +0000 (UTC) Received: from localhost ([::1]:52126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifp7w-0007PM-Qv for normalperson@yhbt.net; Fri, 13 Dec 2019 12:53:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38569) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifp7s-0007P7-Sq for bug-gnulib@gnu.org; Fri, 13 Dec 2019 12:53:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifp7r-0005Sn-TM for bug-gnulib@gnu.org; Fri, 13 Dec 2019 12:53:16 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42667) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifp7r-0005QW-Nk for bug-gnulib@gnu.org; Fri, 13 Dec 2019 12:53:15 -0500 Received: by mail-wr1-f66.google.com with SMTP id q6so344555wro.9 for ; Fri, 13 Dec 2019 09:53:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oII2DAOcpoqa0v2twFF1fpdt9182MErbN9oYY0+S1Yc=; b=FVAGX8fEdFxmBCUwpZMePDxGvN7ChAaxUQzek+qYW+iDOESzAiaUevZhKVFJchjJEL ql1nhw/ifPQCrC8Hkb24hrzkDUjXpgzPNadCbNKzTM9x1vwW3c2lgYwzL9tKTVE1pdU2 jImgqDUUJjTyPgSwyNZJG8AHrLA/3I1aNHrNp44W9B0h7RDZtKfdTn2jrrQy8jR0KJo5 Sq/ma6Ja6MFXALC4creYpwFWdYzNIwhADxlPlgMOf/LRx+ltHAhjgOMhUul+NizWTTNQ 2JOa0AFO8xcQjCN6ns37kWjPC/SUrUwu0BUj/A4+sXV0QIsJlykoV6FBFLvsfGz1rtWI B/Cw== X-Gm-Message-State: APjAAAX4SEaoCi2d4itgfK0Nu7pZ/Wr0WQgpFrW3Prr/lmSqOL3dLhRF 5zSPzDWgliRmIyMOBHhAnKrn0i/rIRog7rdgbM4= X-Google-Smtp-Source: APXvYqwQ9N7L/5ZGPjPyj03swHoWW8e8PDL72Ld2K1CUdr9zLmNf6S8WKeHSqF6wi4wtv18cXPI1Sd9z1xn67LiI1i4= X-Received: by 2002:a5d:4386:: with SMTP id i6mr14221502wrq.63.1576259594008; Fri, 13 Dec 2019 09:53:14 -0800 (PST) MIME-Version: 1.0 References: <20190323080618.E6EB.27F6AC2D@kcn.ne.jp> <20190323114902.E6F6.27F6AC2D@kcn.ne.jp> <75091466-e105-c35c-fcd6-19ccca325914@cs.ucla.edu> <201912120731.xBC7V6gD031767@freefriends.org> <38194689-56ba-41f4-3810-50df1ff9019c@cs.ucla.edu> <201912130809.xBD89uUG021729@freefriends.org> <201912131208.xBDC8QLo032709@freefriends.org> In-Reply-To: <201912131208.xBDC8QLo032709@freefriends.org> From: Jim Meyering Date: Fri, 13 Dec 2019 09:53:01 -0800 Message-ID: Subject: Re: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher To: Aharon Robbins Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.66 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Eggert , "bug-gnulib@gnu.org List" , Norihiro Tanaka , 34951@debbugs.gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Fri, Dec 13, 2019 at 4:08 AM wrote: > arnold@skeeve.com write: > > > But I really don't want ptrdiff_t in the API. > > I see that Paul has made the change to the API over my objections. > > Jim --- do you have an opinion on this? Hi Aharon, I used to feel the way you do. However, given the way compilers and static/dynamic analysis have evolved, I have come around to Paul's point of view. It still feels "wrong" in some sense, but using the signed type makes the code more robust, enabling automatic detection/avoidance of more bugs than with unsigned types. Thus, a net improvement. Paul, can you point to a link that lists the benefits/tradeoffs? If I had such a link handy, I would have provided it here. Jim