From: Jim Meyering <jim@meyering.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: fryasu@yahoo.co.jp, Gnulib bugs <bug-gnulib@gnu.org>,
40634@debbugs.gnu.org, Norihiro Tanaka <noritnk@kcn.ne.jp>,
GNU grep developers <grep-devel@gnu.org>
Subject: Re: bug#40634: Massive pattern list handling with -E format seems very slow since 2.28.
Date: Mon, 14 Sep 2020 07:14:14 -0700 [thread overview]
Message-ID: <CA+8g5KG9_CGnBXtLA2UVOToFdKFStEzXAeY0vM6mpwTZsBwrgA@mail.gmail.com> (raw)
In-Reply-To: <78d13c9d-0426-b913-66fc-d7d652a5500c@cs.ucla.edu>
On Sun, Sep 13, 2020 at 7:03 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
> On 9/11/20 11:41 PM, Jim Meyering wrote:
> >> https://bugs.gnu.org/40634#32
> >>
> >> I'll try to take a look at the later patch.
> >
> > Oh! Glad you spotted that.
>
> I took a look and the basic idea sounds good though I admit I did not check
> every detail. While looking into it I found some opportunities for improvements,
> plus I found what appear to be some longstanding bugs in the area, one of which
> causes a grep test failure on Solaris (and I suspect the bug is also on
> GNU/Linux but the grep tests don't catch it). I installed the attached patches
> into Gnulib, updated grep to point to the new Gnulib version, and added a note
> in grep's NEWS file about this.
>
> Patch 1 is what Norihiro Tanaka proposed in Bug#40634#32, except I edited the
> commit message. Patch 2 consists of minor cleanups and performance tweaks for
> Patch 1. (Patches 3 and 4 are omitted as they were installed by others into
> Gnulib at about the same time I was installing these.) Patch 5 fixes a
> dfa-heap-overrun failure on Solaris that appears to be a longstanding bug
> exposed by Patch 1 when running on Solaris. Patch 6 merely cleans up code near
> Patch 5. Patch 7 fixes the use of an uninitialized constraint, which I
> discovered while debugging Patch 5 under Valgrind; this also appears to be a
> longstandiung bug.
>
> Coming up with test cases for all these bugs would be pretty tricky, unfortunately.
Wow! Thank you!
next prev parent reply other threads:[~2020-09-14 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6503eb8e-e6fd-b4dd-aab7-76bb6955d87b@cs.ucla.edu>
[not found] ` <20200417093536.875E.27F6AC2D@kcn.ne.jp>
2020-04-17 1:24 ` bug#40634: Massive pattern list handling with -E format seems very slow since 2.28 Norihiro Tanaka
2020-04-17 15:22 ` Norihiro Tanaka
2020-04-18 22:41 ` Norihiro Tanaka
2020-04-19 2:10 ` Norihiro Tanaka
2020-09-11 12:47 ` Jim Meyering
2020-09-11 13:17 ` Jim Meyering
2020-09-11 23:01 ` Paul Eggert
2020-09-12 6:41 ` Jim Meyering
2020-09-14 2:03 ` Paul Eggert
2020-09-14 14:14 ` Jim Meyering [this message]
2020-09-21 19:22 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+8g5KG9_CGnBXtLA2UVOToFdKFStEzXAeY0vM6mpwTZsBwrgA@mail.gmail.com \
--to=jim@meyering.net \
--cc=40634@debbugs.gnu.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=fryasu@yahoo.co.jp \
--cc=grep-devel@gnu.org \
--cc=noritnk@kcn.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).