From: Jim Meyering <jim@meyering.net>
To: "bug-gnulib@gnu.org List" <bug-gnulib@gnu.org>
Subject: [PATCH] update-copyright: reenable its always-skipped test
Date: Sat, 4 Jan 2020 22:54:14 -0800 [thread overview]
Message-ID: <CA+8g5KF9L1t-cMJwMz=Jw0Zm6yfNDM32iMqhtfFPdZMH+WKygw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 40 bytes --]
Here's another that I'll push tomorrow:
[-- Attachment #2: always-skipped-update-copyright-test.diff --]
[-- Type: application/octet-stream, Size: 1672 bytes --]
From ae8d0e6326794d98c5f0db6ff11ba61f4602d264 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@fb.com>
Date: Sat, 4 Jan 2020 22:52:20 -0800
Subject: [PATCH] update-copyright: reenable its always-skipped test
* tests/test-update-copyright.sh: Restore the "-pi" options removed
on 2019-06-15. Without those, an internal preliminary test would
fail, causing this test always to be skipped.
---
ChangeLog | 5 +++++
tests/test-update-copyright.sh | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 730f53727..7c8b90ed2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2020-01-04 Jim Meyering <meyering@fb.com>
+ update-copyright: reenable its always-skipped test
+ * tests/test-update-copyright.sh: Restore the "-pi" options removed
+ on 2019-06-15. Without those, an internal preliminary test would
+ fail, causing this test always to be skipped.
+
stdlib: avoid canonicalize_file_name contradiction
* lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull
attribute from its declaration. tests/test-canonicalize-lgpl.c
diff --git a/tests/test-update-copyright.sh b/tests/test-update-copyright.sh
index b59f83599..adba7799f 100755
--- a/tests/test-update-copyright.sh
+++ b/tests/test-update-copyright.sh
@@ -51,7 +51,7 @@ cat <<\EOF > $s
# the script through the perl program found in $PATH. The '-x' option
# is essential as well; without it, perl would re-execute the script
# through /bin/sh. When executed by perl, the next two lines are a no-op.
-eval 'exec perl -wSx "$0" "$@"'
+eval 'exec perl -wSx -pi "$0" "$@"'
if 0;
s/a/b/
--
2.24.0.390.g083378cc35
next reply other threads:[~2020-01-05 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 6:54 Jim Meyering [this message]
2020-01-05 7:14 ` [PATCH] update-copyright: reenable its always-skipped test Bruno Haible
2020-01-05 17:11 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+8g5KF9L1t-cMJwMz=Jw0Zm6yfNDM32iMqhtfFPdZMH+WKygw@mail.gmail.com' \
--to=jim@meyering.net \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).