* snippet/_Noreturn: Fix typo
@ 2021-08-12 7:34 Akim Demaille
2021-08-12 21:29 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Akim Demaille @ 2021-08-12 7:34 UTC (permalink / raw
To: Gnulib bugs
From a report by Christopher Nielsen <mascguy@github.com> about Bison (which uses an almost verbatim copy of this snippet).
<https://trac.macports.org/ticket/59927#comment:59>
<https://trac.macports.org/ticket/59927#comment:62>
Cheers!
commit 964ce0a92b9ba87afe7787dc0fd5d1e1abe7214c
Author: Akim Demaille <akim.demaille@gmail.com>
Date: Thu Aug 12 09:30:41 2021 +0200
snippet/_Noreturn: Fix typo
* lib/_Noreturn.h: Fix spelling of 4.
diff --git a/ChangeLog b/ChangeLog
index 037fa7da4..b8a93468d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2021-08-12 Akim Demaille <akim@lrde.epita.fr>
+
+ snippet/_Noreturn: Fix typo
+ * lib/_Noreturn.h: Fix spelling of 4.
+
2021-08-11 Paul Eggert <eggert@cs.ucla.edu>
dynarray: merge from glibc
diff --git a/lib/_Noreturn.h b/lib/_Noreturn.h
index cb72f2620..6fed3c797 100644
--- a/lib/_Noreturn.h
+++ b/lib/_Noreturn.h
@@ -29,7 +29,7 @@
# elif ((!defined __cplusplus || defined __clang__) \
&& (201112 <= (defined __STDC_VERSION__ ? __STDC_VERSION__ : 0) \
|| (!defined __STRICT_ANSI__ \
- && (__4 < __GNUC__ + (7 <= __GNUC_MINOR__) \
+ && (4 < __GNUC__ + (7 <= __GNUC_MINOR__) \
|| (defined __apple_build_version__ \
? 6000000 <= __apple_build_version__ \
: 3 < __clang_major__ + (5 <= __clang_minor__))))))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: snippet/_Noreturn: Fix typo
2021-08-12 7:34 snippet/_Noreturn: Fix typo Akim Demaille
@ 2021-08-12 21:29 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2021-08-12 21:29 UTC (permalink / raw
To: Akim Demaille; +Cc: Gnulib bugs
On 8/12/21 12:34 AM, Akim Demaille wrote:
> - && (__4 < __GNUC__ + (7 <= __GNUC_MINOR__) \
> + && (4 < __GNUC__ + (7 <= __GNUC_MINOR__) \
Oh, good catch! I introduced this bug on January 9 in
077ffc1e416a6be980dd45979547201e572962f6. It's lucky that the bug causes
noisy build-time failures.
The bug affects only GCC and compilers that pretend to be GCC. Also, the
bug affects neither GCC 4.7 (2012) and later, nor clang 3.5 (2014) and
later. This may help explain why the typo wasn't noticed earlier.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-12 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-12 7:34 snippet/_Noreturn: Fix typo Akim Demaille
2021-08-12 21:29 ` Paul Eggert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).