From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0F9EF1F466 for ; Sun, 26 Jan 2020 22:50:38 +0000 (UTC) Received: from localhost ([::1]:37868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivqjl-0004nb-7u for normalperson@yhbt.net; Sun, 26 Jan 2020 17:50:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60378) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivqjg-0004nH-Vp for bug-gnulib@gnu.org; Sun, 26 Jan 2020 17:50:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivqjf-00051d-WC for bug-gnulib@gnu.org; Sun, 26 Jan 2020 17:50:32 -0500 Received: from smtpweb146.aruba.it ([62.149.158.146]:55925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ivqjf-0003no-LR for bug-gnulib@gnu.org; Sun, 26 Jan 2020 17:50:31 -0500 Received: from [192.168.126.128] ([146.241.70.103]) by smtpcmd05.ad.aruba.it with bizsmtp id vAqW2100L2DhmGq01AqXTR; Sun, 26 Jan 2020 23:50:31 +0100 Subject: Re: [PATCH] lib/gettext.h: fix warning if gettext is already present From: Giulio Benetti To: Bruno Haible , bug-gnulib@gnu.org References: <20200126181929.38457-1-giulio.benetti@benettiengineering.com> <1852089.F2OspKUfUd@omega> Message-ID: <9c7f7d16-e2a3-6b72-158c-cb5cabe69196@benettiengineering.com> Date: Sun, 26 Jan 2020 23:50:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1580079031; bh=dtkVNrlze/cJxmYdjD+UXrtWSFP66PEBPSoQx3a4iu8=; h=Subject:From:To:Date:MIME-Version:Content-Type; b=LJ/rhszbn/K5L4FJ++v+SR7ermlLj05Pcb/HiETiFZ1iWahaxdTGwUqTN8OjJSYj2 rVkmoWbE9hOTQKnD1PoWLI/aVvpkBa+b+vJaOMQOMWdFYmax9cGzbH6+3EA8g3/j0d wKaYY02vC0Ck8bVITQZqMnQd5KTpxW7lK/7lfRsYgXRfzGRYB/rf42eAxJBxk6yhbV ljVf/IT4tFpdmlG/YjeNoZC3qvhnstk5bMXg5t/JBwl9oIrz93dZKhvjt+dSvSj26C 6/zn2k2yY5ccdhbdgs/mrPKU1RQofLICbOycy1vLAQ31OBOGJ2303l2rpWGm02j6I9 +GW9Uo3B+sCHg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 62.149.158.146 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 1/26/20 11:47 PM, Giulio Benetti wrote: > Hi Bruno, > > On 1/26/20 11:12 PM, Bruno Haible wrote: >> Hi Giulio, >> >>> Building on an environment where gettext is already present leads to >>> emitting a warning about gettext_noop() alread defined. >> >> Where is the first definition of gettext_noop located? In another copy >> of gettext.h? In a third-party .h file? Or in the .c file that is being >> compiled? > > In a entire gettext. In my specific case I'm adding package libbytesize Here ^^^^^^^^^^^^^^^^ I meant: In a environment where gettext is already installed. > [1], where they add src/gettext.h but they define ENABLE_NLS in any case > [2]. Maybe configure.ac should define it or not according to gettext > presence... What do you think? > > Here I've opened a pull request: > https://github.com/storaged-project/libbytesize/pull/64 > > The goal is to add libbytesize to Buildroot. > > [1]: https://github.com/storaged-project/libbytesize > [2]: > https://github.com/storaged-project/libbytesize/blob/master/configure.ac#L21 > -- Giulio Benetti Benetti Engineering sas