bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Collin Funk <collin.funk1@gmail.com>
Subject: Re: [PATCH] gnulib-tool.py: Fix configure.ac output.
Date: Tue, 27 Feb 2024 23:39:04 +0100	[thread overview]
Message-ID: <9752980.alqRGMn8q6@nimes> (raw)
In-Reply-To: <30dfd4da-cde7-4c82-9c54-7a02c3a6910c@gmail.com>

Collin Funk wrote:
> When running the following command,
> 
> gnulib-tool.py --create-testdir --dir test-dir-python dummy
> 
> creates a configure.ac like so:
> 
> gl_source_base='gllib'
> 
> \
>   m4_ifval(gl_LIBSOURCES_LIST, [
>     m4_syscmd([test ! -d ]m4_defn([gl_LIBSOURCES_DIR])[ ||
> ...
>     AC_SUBST([gl_LIBOBJS], [$gl_libobjs])
>     AC_SUBST([gl_LTLIBOBJS], [$gl_ltlibobjs])
>   ])\n  LIBGNU_LIBDEPS="$gl_libdeps"
> ...

Indeed, that's not right.

Thanks for the patch; applied.

> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=f00ef30ee0a68bf91cfd081afc784cb8ffd00656
> 
> I assume that this string literal was changed to a raw string [1] in
> order to avoid having to escape a sed statement. Since it is already
> wrapped in triple quotes we can just add a newline in the code

I guess I wasn't very familiar with raw strings when I did this change.

Bruno





  reply	other threads:[~2024-02-27 22:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 22:31 [PATCH] gnulib-tool.py: Fix configure.ac output Collin Funk
2024-02-27 22:39 ` Bruno Haible [this message]
2024-02-27 23:01   ` Collin Funk
2024-02-27 23:39     ` Bruno Haible
2024-02-28  0:04       ` Collin Funk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9752980.alqRGMn8q6@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=collin.funk1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).