bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: Use module 'c99' when needed for variadic macros with '...' syntax
Date: Sat, 05 Sep 2020 20:05:00 +0200	[thread overview]
Message-ID: <9537780.Y9riU2t58W@omega> (raw)

When compiling a gnulib testdir with CC="gcc -std=gnu90 -pedantic" (without
the 'c99' module) I see these warnings:

./malloc/scratch_buffer.h:107:55: warning: ISO C99 requires at least one argument for the "..." in a variadic macro
./malloc/scratch_buffer.h:124:56: warning: ISO C99 requires at least one argument for the "..." in a variadic macro
./malloc/scratch_buffer.h:95:46: warning: ISO C99 requires at least one argument for the "..." in a variadic macro
sm3.c:409:48: warning: ISO C99 requires at least one argument for the "..." in a variadic macro

Thus, the modules 'scratch_buffer' and 'crypto/sm3' are effectively already
using C11. C90 compilers surely will reject this syntax.


2020-09-05  Bruno Haible  <bruno@clisp.org>

	Use module 'c99' when needed for variadic macros with '...' syntax.
	* modules/crypto/sm3 (Depends-on): Add c99.

diff --git a/modules/crypto/sm3 b/modules/crypto/sm3
index 007fbc4..3df7d88 100644
--- a/modules/crypto/sm3
+++ b/modules/crypto/sm3
@@ -8,6 +8,7 @@ m4/sm3.m4
 
 Depends-on:
 byteswap
+c99
 extern-inline
 stdalign
 stdint



                 reply	other threads:[~2020-09-05 18:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9537780.Y9riU2t58W@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).