From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 272D81F44D for ; Thu, 25 Apr 2024 12:07:51 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=XT+MGNw5; dkim=fail reason="signature verification failed" header.d=clisp.org header.i=@clisp.org header.a=ed25519-sha256 header.s=strato-dkim-0003 header.b=/4vTK2fK; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzxt2-00071O-7X; Thu, 25 Apr 2024 08:07:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzxsz-000713-4b for bug-gnulib@gnu.org; Thu, 25 Apr 2024 08:07:33 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzxsw-0001cP-Vi for bug-gnulib@gnu.org; Thu, 25 Apr 2024 08:07:32 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1714046848; cv=none; d=strato.com; s=strato-dkim-0002; b=pPxqIQ4pCO0X8X75X+VOKbglN0pOp2A6bF+M/BkKc8bNfgK8WOsOGOBmB+R3Tsjjz4 Zm1F/DrjI83KLQSYgGCNjvtgC7OZfcg7tHdy5DRXb2Tix/Jz05BKLb+Jii3MXHaxTmoE OvP+6aGgQHYbS8cu4zPsWIYG3Jwh9117fm+Mbv0uk8FY0DyGOT0K5LJf6dgqOXmLRGXm lPMDELLV7TR70ksJSMNpUxcNjeWNHsTDuF75oAHK1J5daAH3b6q1lp7LkHws8GMOBM+6 bpAuyLLoLeqiPFJOwd5aQfCQayBgmBh9SrB9JepnXYfcp+KnOR8q5KWG7r2ho4eFUu0/ NOCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1714046848; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=r33/PfeONqWFajRXKQ/PPlXJ70tjSFyNkqWdZLxWZuQ=; b=YxZ+mPywTzlHXCtQCgRqWu7evq7413fZBXMrA7Zu3SeGzoC9Wxx/oJ53TWOIw1HxlT xbyKDmOn/hsHg6EMNd2GnFqmvhhzsLBUqknDGpTztamrjCRVBbhdZ1XmGDpyK6nz8tkB FYtLG6mi6oPYK2Ob+OE9XLkl+qYn/ZaO4YYqeIMLMOItnx3xVblijWQKxIo6uvGmQKjp VxCEbGRnF0+YzIknnYUUfmqyPgdmeCaCTJM4heIjk4KmPWq+aQAhDaejE2uiVESnHHVk WU6xUh4e8SAjDPJ4v/xLMwwueklutVew+jDWo479/NiJCgiphEckEfFq+PclzX6wCtyj PY4A== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1714046848; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=r33/PfeONqWFajRXKQ/PPlXJ70tjSFyNkqWdZLxWZuQ=; b=XT+MGNw5mxyK0L1zzRWWa131sI4aad1lNh90z3IwRz2GrYSnPraXeKv9xpEz9rlYIx XNBoUGjOXMZvJ15xyzRaL/r0CcBZDfPDxk4K5BS2CRcKMURns0N9bZM+7YuEH+gXJ8SL s333OfoYQHcqNMcQvAIwQPEkuHIqGtPtydrZZMBeTJ95T7F7UM4eQvRVComOfxUrKsMJ 9/zS5ROE5Kajkr6BKxpxVLrsjtCwWiWbehrgmsCoRNarWcNgSNY2fOVKlu/836WtELeH PDr5k/iBIKwncz2WRSkRbtGaUYbVOvcJwXEqkoAEOZQ0oj+TGZrQny4KGmUyV/nmIHjL zhGA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1714046848; s=strato-dkim-0003; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=r33/PfeONqWFajRXKQ/PPlXJ70tjSFyNkqWdZLxWZuQ=; b=/4vTK2fKXZwC0rU5Xp0MFx7fxrJ9JoNVYSBKtvmbao4149vaJNsPT8/a4AJCdW96KG 2F8IGssfgyLubRmMOWDQ== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOe3vCV4oRKystmTLSuNMWD8bLLMg==" Received: from nimes.localnet by smtp.strato.de (RZmta 50.5.0 AUTH) with ESMTPSA id Ndd2ca03PC7SBiP (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 25 Apr 2024 14:07:28 +0200 (CEST) From: Bruno Haible To: Reuben Thomas Cc: bug-gnulib Subject: Re: 'relocatable' project built without --enable-relocatable Date: Thu, 25 Apr 2024 14:07:27 +0200 Message-ID: <9180429.mT2jXtDnLo@nimes> In-Reply-To: References: <6069206.YavUGHks2N@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.161; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Reuben Thomas wrote: > > Can you please try the attached patch? > > Works beautifully, thanks. OK, I'm committing as shown below. > Is there a reason not to make a similar macro for compute_curr_prefix? Yes: - For compute_curr_prefix, the need has not been demonstrated. - Even if ENABLE_RELOCATABLE is 1, there are cases when compute_curr_prefix is not defined. 2024-04-25 Bruno Haible relocatable-lib-lgpl: Allow unconditional use of set_relocation_prefix. Reported by Reuben Thomas in . * lib/relocatable.h (set_relocation_prefix): Define in a dummy way if ENABLE_RELOCATABLE is not defined. diff --git a/lib/relocatable.h b/lib/relocatable.h index 162f9d82a4..0c10ebe2a1 100644 --- a/lib/relocatable.h +++ b/lib/relocatable.h @@ -109,6 +109,8 @@ extern char * compute_curr_prefix (const char *orig_installprefix, #else /* By default, we use the hardwired pathnames. */ +#define set_relocation_prefix(orig_prefix, curr_prefix) \ + ((void) (orig_prefix), (void) (curr_prefix)) #define relocate(pathname) (pathname) #define relocate2(pathname,allocatedp) (*(allocatedp) = NULL, (pathname))