From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 193271F45A for ; Sat, 29 Oct 2022 22:10:06 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.b="j/FFUX1/"; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oou1e-0000Eg-IG; Sat, 29 Oct 2022 18:09:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oou1c-0000E3-VB; Sat, 29 Oct 2022 18:09:57 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.165]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oou1b-0003Dn-6a; Sat, 29 Oct 2022 18:09:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1667081390; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=dRjz1pJdGJH5nJLGYkkX3BKQBSlBtveSS69WU8HKhVg=; b=j/FFUX1/BwLsZN4OfiT/4xtTNfBE/BvI15UmY5/Wcebb6tkAPOCO4LoMHcdxCKjyvC LZKNXs+K0EQev1i/Bzt5+OJEQMdODHCLKFZGxCDLogN+3oWagXfMhT0AnpMcIhsbvN7T gIPk5nJnVDurKyPnrDWNxAQSlmmga4cz6AEmBlqcIA67B9IkBnhOsJWeWTDy5FtOWvUE X06yqdI/eVJGrjgWU3bWA1jGpT4HdrTamPgPOW7caNR52ZQrGxC7nHsS3vuOzdfRFw4n ndIUm/nT8TgN8srd1XxqhPRWg0YYukhFAAFiYoxxWTzr8JkRWrL2qtl7Gd7uAmigAE3e zQqA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpPD2feZnFI1EukB7hdjgBUPf8RCcA==" X-RZG-CLASS-ID: mo00 Received: from nimes.localnet by smtp.strato.de (RZmta 48.2.1 AUTH) with ESMTPSA id v9c7e6y9TM9oWBg (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 30 Oct 2022 00:09:50 +0200 (CEST) From: Bruno Haible To: Gavin Smith , Bruno Haible , bug-gnulib@gnu.org, bug-texinfo@gnu.org Subject: Re: Avoid gnulib redefinitions - MDA Date: Sun, 30 Oct 2022 00:09:50 +0200 Message-ID: <8965388.O52NOvI7LO@nimes> In-Reply-To: References: <1791297.4MS8fQxZnU@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.165; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-gnulib" Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Gavin Smith wrote: > so it sounds like we are better off using #undef before > including the Perl headers to avoid depending on undocumented > functionalities. Thanks. Using #undef means to decline all corrections done by Gnulib. These are documented in the manual. For example, for 'fdopen' [1] we have documented Portability problems fixed by Gnulib: This function crashes when invoked with invalid arguments on some platforms: MSVC 14. On Windows platforms (excluding Cygwin), this function does not set errno upon failure. So, if you always use fdopen() with correct arguments and if, in case of a NULL return of this function, the code does not look at errno, then the '#undef fdopen' is OK. (On those platforms where the Microsoft deprecated alias still work, or when it is overridden by a redirect to some perl internal function.) Bruno [1] https://www.gnu.org/software/gnulib/manual/html_node/fdopen.html