From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C75AC1F4B4 for ; Tue, 19 Jan 2021 17:39:01 +0000 (UTC) Received: from localhost ([::1]:51996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1uy4-0007SL-Qj for normalperson@yhbt.net; Tue, 19 Jan 2021 12:39:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1ucR-0005u8-Dj for bug-gnulib@gnu.org; Tue, 19 Jan 2021 12:16:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1ucM-0006Aj-EY for bug-gnulib@gnu.org; Tue, 19 Jan 2021 12:16:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611076592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ycNuS0LFcfCaVW921gyEBJZId1ozfYxchkKQBknDP1Q=; b=cyQbbEDLXT4xUjpwEuFjQxWEdEEACmsKlFLf9+IiFu3UjwX+lO8pA1o2Agho0GqifwUUyO 9EvBrK4oe99rbTbOtUWNnuYUo7YggX+9gwHNWI+BR53IGTzxtT9Yhx3mlVEbYoWcTnFull NUqJJiHrsKE/r7HammanBvScQWmePAI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-U3EQWoVKO1WW00piPYwX_g-1; Tue, 19 Jan 2021 12:16:28 -0500 X-MC-Unique: U3EQWoVKO1WW00piPYwX_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 508C110074C0; Tue, 19 Jan 2021 17:16:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-110.ams2.redhat.com [10.36.112.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D797A60CCB; Tue, 19 Jan 2021 17:16:25 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib References: <20201230201507.2755086-1-adhemerval.zanella@linaro.org> <909632B5-141E-4567-8E62-3DAF91CB8E33@arm.com> <74ac97a1-2186-1937-4595-ab7409d663d0@linaro.org> <8735yw98dz.fsf@oldenburg.str.redhat.com> Date: Tue, 19 Jan 2021 18:16:20 +0100 In-Reply-To: (Adhemerval Zanella's message of "Tue, 19 Jan 2021 14:11:09 -0300") Message-ID: <87y2go7spn.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=fweimer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=fweimer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.195, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "bug-gnulib@gnu.org" , Paul Eggert , Adhemerval Zanella via Libc-alpha , Vaseeharan Vinayagamoorthy Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" * Adhemerval Zanella: > On 19/01/2021 13:52, Florian Weimer wrote: >> * Adhemerval Zanella via Libc-alpha: >> >>> Paul, this seemed to a common pattern scatter on multiple file in gnulib. >>> Wouldn't be better to consolidate it on cdefs.h? >> >> gnulib shouldn't be using cdefs.h on glibc systems, so I think a >> separate header would be needed. > > What is the problem of using cdefs.h for internal implementation? Isn't regex_internal.h sync'ed with gnulib? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill