From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E26C81F910 for ; Thu, 3 Nov 2022 11:05:26 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="gPtkV3ai"; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqY20-0007gC-TR; Thu, 03 Nov 2022 07:05:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqY1w-0007cY-3x for bug-gnulib@gnu.org; Thu, 03 Nov 2022 07:05:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqY1u-0000v7-FT for bug-gnulib@gnu.org; Thu, 03 Nov 2022 07:05:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667473501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=moOPru2f7NIFhrRyh2VKh27DrufY5uZ5kxEMhHeuV6A=; b=gPtkV3aitfdV5ojowOQu9vLfVpnQIBu/212PeudDEep17aYnr4AKMse243VbekxJjB2V/a auUVSw24Qtqg3LF6MFgwoetr0q0sD+alBrPxOqk7A/olLtNS4svpJ/nB46nBIhXOMdXC3y 1d6x//0O/2srLYMH9fdp/rjWneYyyuo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-258-XweRpaeUNs-x5k9Dil1lVA-1; Thu, 03 Nov 2022 07:03:27 -0400 X-MC-Unique: XweRpaeUNs-x5k9Dil1lVA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 16A42185A7A9; Thu, 3 Nov 2022 11:03:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CEA6540C83AD; Thu, 3 Nov 2022 11:03:25 +0000 (UTC) From: Florian Weimer To: Bruno Haible Cc: bug-gnulib@gnu.org, Paul Eggert , Karl Berry Subject: Re: scratch_buffer.h, scratch_buffer_dupfree.c sync References: <202211022237.2A2Mb6uK000339@freefriends.org> <3611769.t68216eyJU@nimes> <6854fb79-d7ec-615f-81f1-9a192ef52828@cs.ucla.edu> <1768975.kWiBISl1fq@nimes> Date: Thu, 03 Nov 2022 12:03:24 +0100 In-Reply-To: <1768975.kWiBISl1fq@nimes> (Bruno Haible's message of "Thu, 03 Nov 2022 11:51:34 +0100") Message-ID: <87v8nwfgg3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=fweimer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.047, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-gnulib" Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org * Bruno Haible: > But when it comes to scratch_buffer or dynarray code, this week's experience > has shown that we cannot count on as much care for Gnulib users. Rather, > the mindset on the glibc side seems to be: "This is glibc internal code; > we can refactor / reshuffle / trim it as we like." [1][2] > > So, if we want to offer a Gnulib module from glibc-internal code, it would > be our job to maintain compatibility across glibc's refactorings. In this > particular case, it would have meant to add the scratch_buffer_dupfree.c > as a Gnulib-owned source file. But it the long run, this is going to be > a growing maintenance effort. (We have a similar situation: gettext's libintl > is derived from glibc/intl/, and it's a continuing effort to keep the two > more or less in sync.) > > Therefore I agree with what you did yesterday: remove scratch_buffer_dupfree.c > from Gnulib, since glibc dropped it. > > But it means that we cannot promise that these .h files are even remotely > stable APIs. I must say I was surprised to see dynarray and scratch_buffer end up in gnulib. I never intended them to escape this way from glibc. The interfaces and their implementation are problematic in some ways, and I can't recommend them for general use. Thanks, Florian