From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 689681F8C6 for ; Wed, 28 Jul 2021 08:08:41 +0000 (UTC) Received: from localhost ([::1]:34540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8ecK-0000cg-A1 for normalperson@yhbt.net; Wed, 28 Jul 2021 04:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8ecG-0000c6-Ar for bug-gnulib@gnu.org; Wed, 28 Jul 2021 04:08:36 -0400 Received: from uggla.sjd.se ([2001:9b1:8633::107]:35692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8ecD-00073M-Je for bug-gnulib@gnu.org; Wed, 28 Jul 2021 04:08:36 -0400 DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=ed2101; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uQnopuRzsGtNnGGXvv1dJVf/ILnAy3tyHXjzC3YNl2g=; t=1627459712; x=1628669312; b=cNFQVfMQ3cZQcIUNbWVAKSPOwUVE+hNSOyDUSAGeK5IZzUdLgbx1Uepo6fkVOQOlo/6ZBBYPOj dXQRbB/4p5DA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=rsa2101; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uQnopuRzsGtNnGGXvv1dJVf/ILnAy3tyHXjzC3YNl2g=; t=1627459712; x=1628669312; b=qbe4TUJ3qIlcvYNuelZkUa31r+WNlcjl836xBt2uCygPj25AXg+VfszP+MgbmHRLzfe3+NWEgV JH7P70YfBM5nwOyEiwTvDHPu+ItGhPDSr6GehQVLLMY4JvUcn1QOXuEoqs9tYRsSmjbkrF3NCLmPU V2w9Q6zFb6gUzPh+Spl5DqyxhQnsJUR8zEoTTcA6ODDp2jVpYPO64jT8SaTn/ojHDoTBg8kWtvJkc 80Og8/YmPHBP0i3f/m0ofszO8Yxub5a7GbD9jMH+C1BUajvT/iVTroLRac58IHr/CVCJb3AFXZpnv iAq4UnEWKXwbuJKKPjGSmns3sLp30I8V5vyCKcyEna+3MObHFIVN/Zu6+o2KUWUU3H4MpFRTm3hsi SaegldChb21lUaEMtB0bLrScNnpH1bVb3DPdnO98cpjy1RSvNDEg97q49OifzIq0Nl97rarLhe ; Received: from [2001:9b1:41ac:ff00:50fc:c7e5:7e78:6f99] (port=51530 helo=latte) by uggla.sjd.se with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8ec9-0001KN-Dc for bug-gnulib@gnu.org; Wed, 28 Jul 2021 08:08:29 +0000 X-Hashcash: 1:22:210728:bug-gnulib@gnu.org::/bhIObSs2FDsiX60:5YAo To: bug-gnulib@gnu.org Subject: fts in gnulib behave different than glibc OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt Date: Wed, 28 Jul 2021 10:08:28 +0200 Message-ID: <87r1fig8sj.fsf@latte.josefsson.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2001:9b1:8633::107; envelope-from=simon@josefsson.org; helo=uggla.sjd.se X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Reply-to: Simon Josefsson From: Simon Josefsson via Gnulib discussion list --=-=-= Content-Type: text/plain Hi. I replaced GNU InetUtils' old custom fts implementation with the one from gnulib, but self-tests started failing. Looking at the code, it seems gnulib's fts implementation has diverged compared to glibc, and has some optimizations that (I think) change the API (wrt stat and chdir). Also, gnulib's fts module is always enabled, even on modern glibc systems. InetUtils's usage of fts works fine with modern glibc, but it didn't work with gnulib's version (it needed a FTS_NOCHDIR). The gnulib manual for the fts replacement module isn't terribly clear about this. Is there a reason for this behaviour? I would prefer if there were two fts modules in gnulib: 1) One module 'fts' based on glibc's code, that is only enabled in on systems that doesn't have fts, or where fts is known to be buggy. 2) One 'fts-faster' that is the current code, which can be used when you always wants to pull in the optimized implementation. Then InetUtils would use system fts on glibc platforms, and not always have to pull in a replacement copy. What do you think? I could live with a new module 'fts-optional' that only pulls in the current 'fts' module when the system is lacking it. That doesn't fix the API confusion, but is probably sufficient for InetUtils. /Simon --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCYQEQfBQcc2ltb25Aam9z ZWZzc29uLm9yZwAKCRBRcisI/kdFovBFAP9r5hiSYUI/kBRdAQHovsemJq9pTpSb 9tM/FUBXxIc77QD+PyY80Qs+QmJ/c8fHK3UbYABL0MdejNRB1hhlHSJwTQQ= =dsx8 -----END PGP SIGNATURE----- --=-=-=--