bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Collin Funk <collin.funk1@gmail.com>
To: Jim Meyering <jim@meyering.net>
Cc: Bruno Haible <bruno@clisp.org>,  bug-gnulib@gnu.org
Subject: Re: syntax-check rule to silence -Winclude-next-absolute-path warning
Date: Mon, 19 Feb 2024 10:11:11 -0800	[thread overview]
Message-ID: <87il2k2ukg.fsf@gmail.com> (raw)
In-Reply-To: <CA+8g5KFVGSaLyzo6XGH6n7fP5wMBKwzCFxgbJLzOxywEeCs-=g@mail.gmail.com> (Jim Meyering's message of "Sun, 18 Feb 2024 21:02:27 -0800")

Jim Meyering <jim@meyering.net> writes:
> Thank you both. I've just pushed an improvement.
> The new version runs grep only once rather than many times, and seems simpler.

Thanks. This one seems much better. It also returns 1 if an invalid
quoted header is found which I forgot to do. This Makefile would
probably be good view for me. :)

I feel like this rule might cause some false positives for some projects
in a few rare cases. Files in the namespace std*.h and sys/*.h probably
shouldn't be used (not sure if they are explicitly reserved). However,
it might be possible that a project uses it's own "error.h" or
"search.h", for example, unrelated to gnulib.

Would it make sense to add an exclude regexp to cfg.mk or make a note
about reserved header names in the documentation?


  reply	other threads:[~2024-02-19 18:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17  8:36 [PATCH] math: Silence -Winclude-next-absolute-path warning Collin Funk
2024-02-17 10:51 ` Bruno Haible
2024-02-17 12:26   ` Collin Funk
2024-02-17 13:17     ` Bruno Haible
2024-02-18 12:19     ` Bruno Haible
2024-02-18 12:44       ` syntax-check rule to silence " Bruno Haible
2024-02-18 20:12         ` Collin Funk
2024-02-18 20:33           ` Bruno Haible
2024-02-19  5:02             ` Jim Meyering
2024-02-19 18:11               ` Collin Funk [this message]
2024-02-19 18:32                 ` Jim Meyering
2024-02-19  8:45             ` Simon Josefsson via Gnulib discussion list
2024-02-19 20:39               ` Jim Meyering
2024-02-20 15:17               ` Bruno Haible
2024-02-20 20:23         ` Collin Funk
2024-02-20 20:49           ` Bruno Haible
2024-02-19  6:31       ` [PATCH] math: Silence " Paul Eggert
2024-02-19 11:03         ` Bruno Haible
2024-02-19 20:41           ` Paul Eggert
2024-02-19 21:24             ` Bruno Haible
2024-02-19 21:45               ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il2k2ukg.fsf@gmail.com \
    --to=collin.funk1@gmail.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=jim@meyering.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).