* test suite failure caused by check-copyright script
@ 2021-05-23 4:11 Maxim Cournoyer
2021-05-23 11:19 ` Bruno Haible
0 siblings, 1 reply; 8+ messages in thread
From: Maxim Cournoyer @ 2021-05-23 4:11 UTC (permalink / raw)
To: bug-gnulib
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
Hello!
I'm discovering this project and attempted to run 'make check'. It
seems to be finding problems, failing with:
--8<---------------cut here---------------start------------->8---
[...]
GPL ?? lib/xstrtoull.c
GPL ?? lib/xstrtoumax.c
GPL ?? lib/gl_xsublist.c
LGPLv2+ GPLv2+ lib/glthread/yield.h
make: *** [Makefile:142: sc_check_copyright] Error 1
Test suite failed, dumping logs.
command "make" "check" failed with status 2
note: keeping build directory `/tmp/guix-build-gnulib-0.1-0.af26171.drv-1'
--8<---------------cut here---------------end--------------->8---
I'm currently using the following dependencies: cppi@1.18 grep@3.4
perl@5.30.2 sed@4.8 texinfo@6.7.
Is this a known problem or is my environment missing something?
Attached is the full log, compressed with gzip.
[-- Attachment #2: test-suite.log.gz --]
[-- Type: application/octet-stream, Size: 10669 bytes --]
[-- Attachment #3: Type: text/plain, Size: 677 bytes --]
Also, I had to run the test suite via a single process, as attempting to
run it in parallel would error with this message near the beginning:
--8<---------------cut here---------------start------------->8---
[...]
+$(shell f=$(gnulib_dir)/lib/intprops.h;
+ perl -lne '$(gl_extract_define_simple)' $$f | sort -u | tr '\n' ' ')
+# Remove trailing space and convert to a regular expression:
make: *** [Makefile:134: sc_check_sym_list] Error 1
make: *** Waiting for unfinished jobs....
make[1]: *** No rule to make target 'syntax-check'. Stop.
make: *** [Makefile:67: sc_maint] Error 2
[...]
--8<---------------cut here---------------end--------------->8---
Thank you,
Maxim
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-23 4:11 test suite failure caused by check-copyright script Maxim Cournoyer
@ 2021-05-23 11:19 ` Bruno Haible
2021-05-24 1:51 ` Paul Eggert
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Bruno Haible @ 2021-05-23 11:19 UTC (permalink / raw)
To: bug-gnulib; +Cc: Maxim Cournoyer
Maxim Cournoyer wrote:
> I'm discovering this project and attempted to run 'make check'. It
> seems to be finding problems, failing with:
>
> --8<---------------cut here---------------start------------->8---
> [...]
> GPL ?? lib/xstrtoull.c
> GPL ?? lib/xstrtoumax.c
> GPL ?? lib/gl_xsublist.c
> LGPLv2+ GPLv2+ lib/glthread/yield.h
> make: *** [Makefile:142: sc_check_copyright] Error 1
It seems we made a decision in November 2011, regarding license
statements in source code files, [1], but did not follow through
with the implementation of this decision: 'check-copyright' reports
more than 2300 failures.
Does everyone still agree
- to put into the source files a license header that is consistent
with the module description, and
- to remove the statement from the documentation
"The source files always say "GPL", but the real license
specification is in the module description file." ?
Bruno
[1] https://lists.gnu.org/archive/html/bug-gnulib/2011-11/msg00191.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-23 11:19 ` Bruno Haible
@ 2021-05-24 1:51 ` Paul Eggert
2021-05-26 17:30 ` Eric Blake
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Paul Eggert @ 2021-05-24 1:51 UTC (permalink / raw)
To: Bruno Haible, bug-gnulib; +Cc: Maxim Cournoyer
On 5/23/21 4:19 AM, Bruno Haible wrote:
> Does everyone still agree
> - to put into the source files a license header that is consistent
> with the module description, and
> - to remove the statement from the documentation
> "The source files always say "GPL", but the real license
> specification is in the module description file." ?
Yes, that still sounds reasonable.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-23 11:19 ` Bruno Haible
2021-05-24 1:51 ` Paul Eggert
@ 2021-05-26 17:30 ` Eric Blake
2021-05-27 14:44 ` Jim Meyering
2021-05-27 15:14 ` Simon Josefsson via Gnulib discussion list
3 siblings, 0 replies; 8+ messages in thread
From: Eric Blake @ 2021-05-26 17:30 UTC (permalink / raw)
To: Bruno Haible; +Cc: bug-gnulib, Maxim Cournoyer
On Sun, May 23, 2021 at 01:19:23PM +0200, Bruno Haible wrote:
> Does everyone still agree
> - to put into the source files a license header that is consistent
> with the module description, and
> - to remove the statement from the documentation
> "The source files always say "GPL", but the real license
> specification is in the module description file." ?
Yes, that's fine with me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-23 11:19 ` Bruno Haible
2021-05-24 1:51 ` Paul Eggert
2021-05-26 17:30 ` Eric Blake
@ 2021-05-27 14:44 ` Jim Meyering
2021-05-27 15:14 ` Simon Josefsson via Gnulib discussion list
3 siblings, 0 replies; 8+ messages in thread
From: Jim Meyering @ 2021-05-27 14:44 UTC (permalink / raw)
To: Bruno Haible; +Cc: bug-gnulib@gnu.org List, Maxim Cournoyer
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Sun, May 23, 2021, 8:05 AM Bruno Haible <bruno@clisp.org> wrote:
> Does everyone still agree
> - to put into the source files a license header that is consistent
> with the module description, and
> - to remove the statement from the documentation
> "The source files always say "GPL", but the real license
> specification is in the module description file." ?
>
Definitely.
>
[-- Attachment #2: Type: text/html, Size: 920 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-23 11:19 ` Bruno Haible
` (2 preceding siblings ...)
2021-05-27 14:44 ` Jim Meyering
@ 2021-05-27 15:14 ` Simon Josefsson via Gnulib discussion list
2021-05-27 17:54 ` Bruno Haible
3 siblings, 1 reply; 8+ messages in thread
From: Simon Josefsson via Gnulib discussion list @ 2021-05-27 15:14 UTC (permalink / raw)
To: Bruno Haible; +Cc: bug-gnulib, Maxim Cournoyer
[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]
Bruno Haible <bruno@clisp.org> writes:
> Maxim Cournoyer wrote:
>> I'm discovering this project and attempted to run 'make check'. It
>> seems to be finding problems, failing with:
>>
>> --8<---------------cut here---------------start------------->8---
>> [...]
>> GPL ?? lib/xstrtoull.c
>> GPL ?? lib/xstrtoumax.c
>> GPL ?? lib/gl_xsublist.c
>> LGPLv2+ GPLv2+ lib/glthread/yield.h
>> make: *** [Makefile:142: sc_check_copyright] Error 1
>
> It seems we made a decision in November 2011, regarding license
> statements in source code files, [1], but did not follow through
> with the implementation of this decision: 'check-copyright' reports
> more than 2300 failures.
>
> Does everyone still agree
> - to put into the source files a license header that is consistent
> with the module description, and
> - to remove the statement from the documentation
> "The source files always say "GPL", but the real license
> specification is in the module description file." ?
Sounds good!
/Simon
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-27 15:14 ` Simon Josefsson via Gnulib discussion list
@ 2021-05-27 17:54 ` Bruno Haible
2021-05-27 18:14 ` Maxim Cournoyer
0 siblings, 1 reply; 8+ messages in thread
From: Bruno Haible @ 2021-05-27 17:54 UTC (permalink / raw)
To: Simon Josefsson; +Cc: bug-gnulib, Maxim Cournoyer
> Sounds good!
>
> /Simon
Thanks for all your voices.
I plan to start implementing this decision this week-end.
Bruno
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: test suite failure caused by check-copyright script
2021-05-27 17:54 ` Bruno Haible
@ 2021-05-27 18:14 ` Maxim Cournoyer
0 siblings, 0 replies; 8+ messages in thread
From: Maxim Cournoyer @ 2021-05-27 18:14 UTC (permalink / raw)
To: Bruno Haible; +Cc: Simon Josefsson, bug-gnulib
Hi Bruno,
Bruno Haible <bruno@clisp.org> writes:
>> Sounds good!
>>
>> /Simon
>
> Thanks for all your voices.
>
> I plan to start implementing this decision this week-end.
Yay! I'll be happy to test it again after then, and report any
remaining problem there may be with running the test suite, so feel free
to ping.
Maxim
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-27 18:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23 4:11 test suite failure caused by check-copyright script Maxim Cournoyer
2021-05-23 11:19 ` Bruno Haible
2021-05-24 1:51 ` Paul Eggert
2021-05-26 17:30 ` Eric Blake
2021-05-27 14:44 ` Jim Meyering
2021-05-27 15:14 ` Simon Josefsson via Gnulib discussion list
2021-05-27 17:54 ` Bruno Haible
2021-05-27 18:14 ` Maxim Cournoyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).