From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CF92A1F5AE for ; Sat, 17 Jul 2021 14:55:51 +0000 (UTC) Received: from localhost ([::1]:32894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4ljK-0001tG-HY for normalperson@yhbt.net; Sat, 17 Jul 2021 10:55:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4ljH-0001t4-75 for bug-gnulib@gnu.org; Sat, 17 Jul 2021 10:55:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4lj8-0001BU-8I for bug-gnulib@gnu.org; Sat, 17 Jul 2021 10:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626533734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4fR3UBSw/g3fbqFEdovNfigq5Be25yvAmi+08ix6Whk=; b=SbVS4eM0fUlqONv7zd7OewyJ41vqQAyoinCn/+rLNhAK3HoZq+mjYpJYYUaNumdzZK1FBw U0BD4yezllPNO50uQnQGfJ8bJXjkL/Rm/DoMeOEDpqAf7Qa6mRt03KIEy9jyOtjHocF2J2 lMjXAV9Ot/f4NniBZyv60j1a0GjfB0Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-r65a1_0yOcSg8zMlCAMRlQ-1; Sat, 17 Jul 2021 10:55:31 -0400 X-MC-Unique: r65a1_0yOcSg8zMlCAMRlQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DCB72100B3AC; Sat, 17 Jul 2021 14:55:29 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-73.phx2.redhat.com [10.3.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DB365C1D0; Sat, 17 Jul 2021 14:55:28 +0000 (UTC) From: Florian Weimer To: Bruno Haible Subject: Re: Undefined use of weak symbols in gnulib References: <87o8e0p92r.fsf@oldenburg.str.redhat.com> <1680226.UWtE2gOZdF@omega> <87a6piluow.fsf@oldenburg.str.redhat.com> <1882380.6EOZElgKgl@omega> Date: Sat, 17 Jul 2021 16:55:26 +0200 In-Reply-To: <1882380.6EOZElgKgl@omega> (Bruno Haible's message of "Sat, 17 Jul 2021 16:38:55 +0200") Message-ID: <87a6mlyopt.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=fweimer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=fweimer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org, libc-alpha@sourceware.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" * Bruno Haible: > Florian Weimer wrote on 2021-04-28: >> However, you should really remove those weak symbol >> hacks. They won't have any effect for glibc 2.34 > > I'm trying to do this now. But what is the right condition? > > 1) I understand that it's only for glibc >= 2.34 on Linux (NPTL), > right? Not on Hurd (HTL)? Yes, Hurd hasn't been integrated. > 2) /usr/include/gnu/lib-names.h still defines LIBPTHREAD_SO. > How about not defining LIBPTHREAD_SO, since linking with it is supposed > to be a no-op in these newer glibc versions? I'm not sure if this is the right way, given that the file still exists for all currently supported targets. An alternative would be to add a macro to , such as PTHREAD_IN_LIBC. Thanks, Florian