‘iconv’ fails to build on NetBSD 5.1

‘iconv’ fails to build on NetBSD 5.1

[Ludovic Courtès]

Hi,

The ‘iconv’ modules fails to build on NetBSD 5.1 (see gcc70 of the GCC
Compile Farm):

--8<---------------cut here---------------start------------->8---
depbase=`echo iconv.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; /bin/ksh ../libtool  --tag=CC    --mode=compile gcc -DHAVE_CONFIG_H  -I. -I../../lib -I..   -I/home/ludo/soft/include -I/usr/pkg/include  -fvisibility=hidden -I/home/ludo/soft/include   -g -O2 -MT iconv.lo -MD -MP -MF $depbase.Tpo -c -o iconv.lo ../../lib/iconv.c && mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../lib -I.. -I/home/ludo/soft/include -I/usr/pkg/include -fvisibility=hidden -I/home/ludo/soft/include -g -O2 -MT iconv.lo -MD -MP -MF .deps/iconv.Tpo -c ../../lib/iconv.c  -fPIC -DPIC -o .libs/iconv.o
../../lib/iconv.c:282: error: conflicting types for 'rpl_iconv'
./iconv.h:388: error: previous declaration of 'rpl_iconv' was here
--8<---------------cut here---------------end--------------->8---

The problem is:

--8<---------------cut here---------------start------------->8---
$ grep ICONV_CONST config.status
S["ICONV_CONST"]=""
D["ICONV_CONST"]=" const"
--8<---------------cut here---------------end--------------->8---

Indeed:

--8<---------------cut here---------------start------------->8---
$ grep ICONV_CONST= configure
    ICONV_CONST=;
--8<---------------cut here---------------end--------------->8---

So it seems that this snippet doesn’t get expanded:

--8<---------------cut here---------------start------------->8---
    m4_ifdef([gl_ICONV_H_DEFAULTS],
      [AC_REQUIRE([gl_ICONV_H_DEFAULTS])
       if test -n "$am_cv_proto_iconv_arg1"; then
         ICONV_CONST="const"
       fi
      ])
--8<---------------cut here---------------end--------------->8---

Ideas?

Thanks,
Ludo’.

Re: ‘iconv’ fails to build on NetBSD 5.1

[Bruno Haible]

Hi Ludo,

> The ‘iconv’ modules fails to build on NetBSD 5.1 (see gcc70 of the GCC
> Compile Farm):

Can you show the gnulib-tool invocations that you used when builting
the tarball of your package? In particular, which of the modules
'iconv', 'iconv-h', 'iconv_open' are used, and which --avoid options
are used?

> The problem is:
> 
> --8<---------------cut here---------------start------------->8---
> $ grep ICONV_CONST config.status
> S["ICONV_CONST"]=""
> D["ICONV_CONST"]=" const"
> --8<---------------cut here---------------end--------------->8---

This shouldn't be.

> Indeed:
> 
> --8<---------------cut here---------------start------------->8---
> $ grep ICONV_CONST= configure
>     ICONV_CONST=;
> --8<---------------cut here---------------end--------------->8---

This shouldn't be either. Can you 'grep serial aclocal.m4' ?

> So it seems that this snippet doesn’t get expanded:
> 
> --8<---------------cut here---------------start------------->8---
>     m4_ifdef([gl_ICONV_H_DEFAULTS],
>       [AC_REQUIRE([gl_ICONV_H_DEFAULTS])
>        if test -n "$am_cv_proto_iconv_arg1"; then
>          ICONV_CONST="const"
>        fi
>       ])
> --8<---------------cut here---------------end--------------->8---

... or maybe you are using a version of iconv.m4 that doesn't contain this
snippet...?

Bruno
-- 
In memoriam Jan Hus <http://en.wikipedia.org/wiki/Jan_Hus>

Re: ‘iconv’ fails to build on NetBSD 5.1

[Ludovic Courtès]

Hi Bruno,

Bruno Haible <bruno@clisp.org> skribis:

>> The ‘iconv’ modules fails to build on NetBSD 5.1 (see gcc70 of the GCC
>> Compile Farm):
>
> Can you show the gnulib-tool invocations that you used when builting
> the tarball of your package? In particular, which of the modules
> 'iconv', 'iconv-h', 'iconv_open' are used, and which --avoid options
> are used?

>From ‘gnulib-cache.m4’:

#   gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --lgpl=3 --no-conditional-dependencies --libtool --macro-prefix=gl --no-vc-files accept alignof alloca-opt announce-gen autobuild bind byteswap canonicalize-lgpl ceil close connect duplocale environ extensions flock floor fpieee frexp full-read full-write func gendocs getaddrinfo getpeername getsockname getsockopt git-version-gen gitlog-to-changelog gnu-web-doc-update gnupload havelib iconv_open-utf inet_ntop inet_pton isinf isnan ldexp lib-symbol-versions lib-symbol-visibility libunistring listen locale log1p maintainer-makefile malloc-gnu malloca nproc open pipe2 putenv recv recvfrom rename send sendto setsockopt shutdown socket stat-time stdlib strftime striconveh string sys_stat trunc verify vsnprintf warnings wchar

So it’s only ‘iconv_open-utf’, but it should drag the other iconv*
modules AIUI.

> This shouldn't be either. Can you 'grep serial aclocal.m4' ?

# iconv.m4 serial 11 (gettext-0.18.1)

This is older than the one in the Gnulib repo I used.

(Time passes...)

The bug originates in Nixpkgs/NixOS, which has a wrapper around
‘aclocal’ to make it honor $ACLOCAL_PATH (this is necessary with Nix
since each package is installed in its own path.)  The problem is that
the wrapper would *prepend* the -I flags corresponding to $ACLOCAL_PATH
instead of appending them, hence the bug.

Sorry for the noise!

Thanks,
Ludo’.