bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: Bernhard Voelker <mail@bernhard-voelker.de>, bug-gnulib@gnu.org
Subject: Re: di-set: Fix memory leak
Date: Thu, 18 Apr 2019 23:42:13 +0200 (CEST)	[thread overview]
Message-ID: <857627614.670465.1555623733644@communicator.strato.com> (raw)
In-Reply-To: <cf4f4b36-a9c3-6a42-07a0-88377ed4943f@bernhard-voelker.de>

Hi Berny,

I would prefer to see the fix in lib/di-set.c, not lib/ino-map.c.
Rationale: in 99% of the uses of the 'ino-map' module, the NULL
check is not needed.

The change to tests/test-di-set.c looks good. If you can commit
that as well?

Thanks.

Apologies for the bug.

Bruno


  reply	other threads:[~2019-04-18 21:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10 13:20 di-set: Fix memory leak Bruno Haible
2019-04-18 21:15 ` Bernhard Voelker
2019-04-18 21:42   ` Bruno Haible [this message]
2019-04-18 22:06     ` Bernhard Voelker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=857627614.670465.1555623733644@communicator.strato.com \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=mail@bernhard-voelker.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).