From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 79B0A1F461 for ; Fri, 5 Jul 2019 01:30:42 +0000 (UTC) Received: from localhost ([::1]:49448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjD3c-0007mr-Fj for normalperson@yhbt.net; Thu, 04 Jul 2019 21:30:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45989) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjD3Y-0007mV-QT for bug-gnulib@gnu.org; Thu, 04 Jul 2019 21:30:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjD3X-00085b-Pi for bug-gnulib@gnu.org; Thu, 04 Jul 2019 21:30:32 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::3]:34422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hjD3X-0007rf-52; Thu, 04 Jul 2019 21:30:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1562290227; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=PwCx5Zui7OndHiOJh/Ue6u+a+YMTsf7QLQJWmeKHKwA=; b=QHT5JESXCsXKtslF1rQI4R0rbndzQ0sgAtjh7mUKkeu3RL47xQIHKQoUcj9EBM558A UQBwlBcWKz0Ifl3IbjJEjjyMIl/DfglBPXKQQgPZ+Inf17ckU9emypqIhvuWZsIjWgBI DQxBXvxkCuKXx7Jnv1GBXfjO49Mjgv7MNwtfvOLMmodu3XofJPbsyEF5GvjJkHn2doC+ 0UdeLiSJzWFVNSDwgQxrPmzINHAuyGD0RUCZaMvMy11UyLty6R4nAkC5iR6Hp1WRyM+p ePq6glGXdNhscgAPXwCQ17xVgwbnRtyrfnIc0ARnywS37UJMIn2Ppwn9PBlsfFqe4SjD Mbwg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGaf0zJZW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.24 DYNA|AUTH) with ESMTPSA id v018bcv651UKOyZ (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 5 Jul 2019 03:30:20 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH] stat: don't explicitly request file size for filenames Date: Fri, 05 Jul 2019 03:30:19 +0200 Message-ID: <8380790.pzPjAAq4OR@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-151-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <7AC7AA2A-EDEA-4A80-9A5A-02FAA2D823EF@whamcloud.com> <5a1b87fe-e265-6b0f-66eb-20ad1ba9c6e5@draigBrady.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::3 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jeff Layton , Andreas Dilger , "coreutils@gnu.org" Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi, Andreas Dilger wrote: > + size_t buf_size = size < initial_limit ? (size ?: 31) + 1 : initial_limit; This syntax is specific to GCC [1]. In patches for gnulib, please stick to portable C99 syntax. Thanks. Bruno [1] https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Conditionals.html