From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 42B051F5AE for ; Thu, 22 Apr 2021 20:28:18 +0000 (UTC) Received: from localhost ([::1]:37976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZfvt-0008IN-57 for normalperson@yhbt.net; Thu, 22 Apr 2021 16:28:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZfvi-0008Hg-D0 for bug-gnulib@gnu.org; Thu, 22 Apr 2021 16:28:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44093) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZfvb-0007Sj-Mv for bug-gnulib@gnu.org; Thu, 22 Apr 2021 16:28:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619123278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DNd6yDQf40B/TGQx/lGwTsrPjNDcREQUxjlsfCp5X1o=; b=CGHMtmE8X+V6VMNy6LgOq+Q3v3fv/Dne53lF124fUSVulR/rZgOXZ6P8xYsCP5vzvRt8SM LAKmBV0IG27o64/OGZtpFY3kdGEaoqrsBOK0/yp2h3meX8UB0BWoOJbfh+p+ypmJ/axfku BXWVO4GxjdX5aivjxVi8xk579tzuZAQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-B9wPAMH_PX-aTUXpJK9DIQ-1; Thu, 22 Apr 2021 16:27:54 -0400 X-MC-Unique: B9wPAMH_PX-aTUXpJK9DIQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C90D343AB; Thu, 22 Apr 2021 20:27:53 +0000 (UTC) Received: from [10.3.113.39] (ovpn-113-39.phx2.redhat.com [10.3.113.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3594C5C1B4; Thu, 22 Apr 2021 20:27:53 +0000 (UTC) Subject: Re: [PATCH 1/8] safe-alloc: improve doc From: Eric Blake To: Paul Eggert , bug-gnulib@gnu.org, berrange@redhat.com References: <20210419040158.1902066-1-eggert@cs.ucla.edu> Organization: Red Hat, Inc. Message-ID: <7fdf7664-5767-ef14-a5d8-c962b5889f4a@redhat.com> Date: Thu, 22 Apr 2021 15:27:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 4/22/21 1:20 PM, Eric Blake wrote: > On 4/18/21 11:01 PM, Paul Eggert wrote: >> * doc/safe-alloc.texi: Clarify that reallocating an array appends >> uninitialized storage. Say ‘sizeof *p’ rather than ‘sizeof(*p)’ >> which would need a space before the paren to follow GNU style. > > Something in you recent malloc work (I'm not yet sure if it was this > particular series) is breaking compilation on Fedora Rawhide: > > CC regex.o > In file included from regexec.c:1368, > from regex.c:74: > ./malloc/dynarray-skeleton.c:195:24: error: expected declaration > specifiers or '...' before '(' token > 195 | __attribute_nonnull__ ((1)) > | ^ > For closure on this thread, my git bisect finally ended at fc6d7d850 "libc-config: port to DragonFlyBSD 5.9" as the point the problem was introduced; but since the fix is already in, this observation is now just for archival purposes -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org