From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A69361F47C for ; Fri, 13 Jan 2023 08:34:29 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=qaCJiwlO; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGFVs-00066A-Nm; Fri, 13 Jan 2023 03:34:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFVq-00065B-Hp for bug-gnulib@gnu.org; Fri, 13 Jan 2023 03:34:10 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.164]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFVk-0002h2-OC for bug-gnulib@gnu.org; Fri, 13 Jan 2023 03:34:07 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1673598830; cv=none; d=strato.com; s=strato-dkim-0002; b=aTFRi3009i1Yl8P2xLgpHtAdZ6RozuAztK6lxKnajayVTCbAhBQw4h56GW7Jn32Fxv IESSyk4uXKExp70hHnMPU1E84dDpsoywoefztA15K0+mV+1g8mRdxP8ULaB/dEkEh2yI z4F7+x9w+n+GDacP5ntf6YTqtbBTwsTR5DLKRqgGZfg1VRJ91iYXq2sgwIyz/2Jt13oe lAfFyxe73qBRIVlYtO30GuYvFqcKu7MCFvzLIrhp8+0VFu2fq+aeT9LJU82o8ivwJI4e kR0OhV7azz9EKVydYROQYaXrgU8EO0mEa1Xz6UDb8KYVK6UK/3qWFYIbogjkoYcPYqqj yPyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1673598830; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=vNBgVFFSxynNooK6pqgj7LT7In8KB0C0wJEbA/7GvjA=; b=j+2w/oWxJMa3aj50uWxg92wmcWHoMzjTP9RPwsZXnQybEP8ady9OI7vN4iXu1gpSO4 bASFTkV7hWPQeuzloVWf/RMxGh6d+HhOKoGrOjLA6JVwvEfFTsAYdTz/kGcMYIrW+E+D OTXGAs4kCgFKGAOxxMKXBD5C3OlfJlR9sgziXs7mxzeO9rbNK9W+osxWqdbwem9Vhewb la/qBR2xNfoHTrj6G07HJTdHZm47oHqF7aI5HcjN4Kr3zqQrHJjKsdea+2JvgIq7H1o3 zdKUPohtng3QdbgNcgolcAqhFZsXSEFolCly/mXbMCdHEiW5z6MkO6RH6wks5uhJepI6 7DRw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1673598830; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=vNBgVFFSxynNooK6pqgj7LT7In8KB0C0wJEbA/7GvjA=; b=qaCJiwlO7OGeEVOD0ysv32/sk5yDRCRaAN7C4WtpMVpmZdTEHyeYw6g6QlJkTFf7a/ 9sEDi+Tzs40PsbGPoS6vKP7R2hfIn6w9kOvNkMgzMVKqGnvVtBzQKsSuZ9rphUDeqMTw CzqC1/mE8aie3H2uK230YoRg/oPEMxxMHY64HrGyijU2bQNJm987tOeqX/QWJXafAb8x IOnwYCTYDt/VE+NO7b4zm6TaQkjvQFV+Fk907th5mNVXgxbUH47bis0CE6DkUYp6PSKY XR1LLfnmvR2ujbbKNp05AVr88diwxobtTrrFjEbDiIik+0MReVor4inxvOvhZdHEjrYN 32Xg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOXjv2XTu3l95++Pe54Opj0GYzUnQ==" Received: from nimes.localnet by smtp.strato.de (RZmta 48.6.2 AUTH) with ESMTPSA id I8f358z0D8XnA1z (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 13 Jan 2023 09:33:49 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org, Ondrej Valousek , Paul Eggert Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c Date: Fri, 13 Jan 2023 09:33:49 +0100 Message-ID: <7698295.mr9Zh2SJbS@nimes> In-Reply-To: References: <20230104143425.1235741-1-ondrej.valousek.xm@renesas.com> <2686288.n97fhnxGW3@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.164; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Paul Eggert wrote: > Sure, as long as the linker dependencies are fixed soon we'll be OK. The linker dependencies are fixed through this patch. It was only a matter of 1) going through all reverse module dependencies, 2) building a testdir of these modules with --enable-xattr and looking out for link errors. 2023-01-13 Bruno Haible qcopy-acl: Adjust link dependencies. * modules/qcopy-acl (Depends-on): Add condition. (configure.ac): Set QCOPY_ACL_LIB. (Link): Add $(QCOPY_ACL_LIB). Remove $(LIB_ACL). * modules/qacl (Link): Add $(LIB_ACL) and $(QCOPY_ACL_LIB). * modules/acl (Link): Add $(LIB_ACL) and $(QCOPY_ACL_LIB). * modules/copy-file (Link): Add $(QCOPY_ACL_LIB). * modules/supersede (Link): Add $(QCOPY_ACL_LIB). * modules/acl-tests (Makefile.am): Link test-copy-acl with $(QCOPY_ACL_LIB). * modules/copy-file-tests (Makefile.am): Link test-copy-file with $(QCOPY_ACL_LIB). * modules/supersede-tests (Makefile.am): Link test-supersede with $(QCOPY_ACL_LIB). diff --git a/modules/acl b/modules/acl index 8bcfd99420..bcc1f4906c 100644 --- a/modules/acl +++ b/modules/acl @@ -22,6 +22,8 @@ Include: Link: $(MBRTOWC_LIB) +$(LIB_ACL) +$(QCOPY_ACL_LIB) License: GPL diff --git a/modules/acl-tests b/modules/acl-tests index 44190b607d..2ee34c6523 100644 --- a/modules/acl-tests +++ b/modules/acl-tests @@ -26,5 +26,5 @@ TESTS += \ TESTS_ENVIRONMENT += USE_ACL=$(USE_ACL) check_PROGRAMS += test-set-mode-acl test-copy-acl test-sameacls test_set_mode_acl_LDADD = $(LDADD) $(LIB_ACL) @LIBINTL@ $(MBRTOWC_LIB) -test_copy_acl_LDADD = $(LDADD) $(LIB_ACL) @LIBINTL@ $(MBRTOWC_LIB) +test_copy_acl_LDADD = $(LDADD) $(LIB_ACL) $(QCOPY_ACL_LIB) @LIBINTL@ $(MBRTOWC_LIB) test_sameacls_LDADD = $(LDADD) $(LIB_ACL) @LIBINTL@ $(MBRTOWC_LIB) diff --git a/modules/copy-file b/modules/copy-file index dac8bd6358..a73e2a474c 100644 --- a/modules/copy-file +++ b/modules/copy-file @@ -37,6 +37,7 @@ Include: Link: $(LIB_ACL) +$(QCOPY_ACL_LIB) $(MBRTOWC_LIB) License: diff --git a/modules/copy-file-tests b/modules/copy-file-tests index 1c554696f9..087797c727 100644 --- a/modules/copy-file-tests +++ b/modules/copy-file-tests @@ -18,4 +18,4 @@ Makefile.am: TESTS += test-copy-file.sh test-copy-file-1.sh test-copy-file-2.sh TESTS_ENVIRONMENT += USE_ACL=$(USE_ACL) check_PROGRAMS += test-copy-file -test_copy_file_LDADD = $(LDADD) $(LIB_ACL) $(CLOCK_TIME_LIB) @LIBINTL@ $(MBRTOWC_LIB) +test_copy_file_LDADD = $(LDADD) $(LIB_ACL) $(QCOPY_ACL_LIB) $(CLOCK_TIME_LIB) @LIBINTL@ $(MBRTOWC_LIB) diff --git a/modules/qacl b/modules/qacl index 45753c7623..445f639f7b 100644 --- a/modules/qacl +++ b/modules/qacl @@ -15,6 +15,10 @@ Makefile.am: Include: +Link: +$(LIB_ACL) +$(QCOPY_ACL_LIB) + License: GPL diff --git a/modules/qcopy-acl b/modules/qcopy-acl index e0cd914953..8dd147927d 100644 --- a/modules/qcopy-acl +++ b/modules/qcopy-acl @@ -6,10 +6,16 @@ lib/qcopy-acl.c m4/xattr.m4 Depends-on: -acl-permissions +acl-permissions [test "$use_xattr" != yes] configure.ac: gl_FUNC_XATTR +if test "$use_xattr" = yes; then + QCOPY_ACL_LIB="$LIB_XATTR" +else + QCOPY_ACL_LIB="$LIB_ACL" +fi +AC_SUBST([QCOPY_ACL_LIB]) Makefile.am: lib_SOURCES += qcopy-acl.c @@ -18,7 +24,7 @@ Include: "acl.h" Link: -$(LIB_ACL) +$(QCOPY_ACL_LIB) License: GPL diff --git a/modules/supersede b/modules/supersede index 3118fad426..1f434fe221 100644 --- a/modules/supersede +++ b/modules/supersede @@ -36,6 +36,7 @@ Include: Link: $(LIB_ACL) +$(QCOPY_ACL_LIB) $(GETRANDOM_LIB) $(CLOCK_TIME_LIB) $(LIBTHREAD) diff --git a/modules/supersede-tests b/modules/supersede-tests index f3a9d777d9..d4b0566b0d 100644 --- a/modules/supersede-tests +++ b/modules/supersede-tests @@ -19,4 +19,4 @@ configure.ac: Makefile.am: TESTS += test-supersede check_PROGRAMS += test-supersede -test_supersede_LDADD = $(LDADD) $(LIB_ACL) $(CLOCK_TIME_LIB) $(GETRANDOM_LIB) $(LIBINTL) $(LIBTHREAD) +test_supersede_LDADD = $(LDADD) $(LIB_ACL) $(QCOPY_ACL_LIB) $(CLOCK_TIME_LIB) $(GETRANDOM_LIB) $(LIBINTL) $(LIBTHREAD)