From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2BA871F47C for ; Sat, 21 Jan 2023 20:04:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=XCY1opub; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJK6U-0003FF-VN; Sat, 21 Jan 2023 15:04:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJK6S-0003Ej-8U for bug-gnulib@gnu.org; Sat, 21 Jan 2023 15:04:40 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJK6P-0003Tg-T5 for bug-gnulib@gnu.org; Sat, 21 Jan 2023 15:04:39 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1674331474; cv=none; d=strato.com; s=strato-dkim-0002; b=QyrHxCpcg6CRCZDcJMS610vaNRxpbih2PeYGQ3Kv7yLw4XMJuiTC3Fvn9vna5sjhyA 4WUKthfpw8KvxUsTWoXInAILSPxrMnNoCs84SpNE6yjc3wyl5uVjZCZkDNKsZ2WZb0Zn dSQvUhB5gXLFfrARqDLZrsFMzoLc1RNX1J7kdx3VHVf0kKEiSBbm1mQWiQ9lyxjgvxAk ID71HpLWOfZLe/UYJsWlMU1T1CTXM0qHZIEkt1vLmWoWJgaqK4x7xai6fpZWdbLYd2Kn HNKmE0bTsZA4iF5VwVK9mytW0qGueLyKGA/Fg2G/dA8pT2Y/EdLMqN4BJrkxclXU49FE mZEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1674331474; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=L6foxkyjB8xOSxn5qV/dATa3NQDqD16ricDxdZzvUPQ=; b=PRaT0MuDLbFjT0pM+/dIbtvF3jgPfKsDomtpdFWXcZHS6PkYc+1WRLGwTrV4AM8ffi B2pq7TdNCY0GLJjjEnhCDKF5JyW+9ZbPpC6F7EJ4Iqsk8XJ9i+ue34A9kyCH1RmN3iLe TNXQgTRadiiAeVWLXyxhUS4GPk3GxN06AYbwUPAtxrwIr06HXKe/zd+3ml3VOV5TpPkY amJ3qh69f2FAr8X3SBepXdRp1ucX6edOW3Jbw9rtEtdIasJGJxB1iKKSGoR0LrDW4U9l xfMW4OvNOZD5/4U04KtIYhv1AUUOAURPdZja0RrdFyG1OP4iw73tS+F+L96D5ukl14Ep RGUw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1674331474; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=L6foxkyjB8xOSxn5qV/dATa3NQDqD16ricDxdZzvUPQ=; b=XCY1opubCa633+Qyg6bONRQ0MFFEFrR8I8tvH9LhYsadmRLTqY7wmLSXPCKawUyWYq NguzJDxXo1XDXZNvSVB+cPrEcM8sph3ejetkVQy67fG22d8Z6SxuJB/VtKcZ+jabpI9H DHd/v79Kwka/9y5iUbckMPGVykLoWvXH1/miSn8e42oMaVpVLOj2BCBQztWCFIPhTt4T yIl4p0yikK8WtbDRnlS6kDb4qLxPdibWThRq/vUWiMWATDoGWkm3n31sHY83Kw1swcSu e6H8WzZVE1DxHushLb40xg2zGbcy2WM+5TE0dHWA5zN3j9/GdPxmyWwCd3Nv2w+WMIc+ NmMQ== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpPC2aS1bIwRG2tcswHQhJjAoX9mAQ==" Received: from nimes.localnet by smtp.strato.de (RZmta 49.1.0 AUTH) with ESMTPSA id w8066ez0LK4Y8QB (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sat, 21 Jan 2023 21:04:34 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: login_tty: Fix detection of declaration Date: Sat, 21 Jan 2023 21:04:34 +0100 Message-ID: <7604482.y9kGjyraZb@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.167; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org One of the changes, two days ago, was wrong: The line gl_CHECK_FUNCS_ANDROID([login_tty], [[#include ]]) causes the declaration check to be performed with on *all* platforms. But the function login_tty is declared in or on BSD platforms. Thus this test fails, ac_cv_func_login_tty comes out as 'no', and Gnulib proceeds to compile the replacement code, although this is not necessary on these platforms. This patch fixes it. 2023-01-21 Bruno Haible login_tty: Fix detection of declaration (regression 2023-01-19). * m4/pty.m4 (gl_FUNC_LOGIN_TTY): Check for the three possible header files. diff --git a/m4/pty.m4 b/m4/pty.m4 index 54523fdac0..f6b5bb3115 100644 --- a/m4/pty.m4 +++ b/m4/pty.m4 @@ -1,4 +1,4 @@ -# pty.m4 serial 16 +# pty.m4 serial 17 dnl Copyright (C) 2010-2023 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -154,8 +154,19 @@ AC_DEFUN([gl_FUNC_LOGIN_TTY], [ AC_REQUIRE([gl_PTY_LIB]) + AC_CHECK_HEADERS_ONCE([utmp.h util.h libutil.h]) gl_saved_libs="$LIBS" LIBS="$LIBS $PTY_LIB" - gl_CHECK_FUNCS_ANDROID([login_tty], [[#include ]]) + gl_CHECK_FUNCS_ANDROID([login_tty], [[ + #include + #if HAVE_UTMP_H + # include + #endif + #if HAVE_UTIL_H + # include + #elif HAVE_LIBUTIL_H + # include + #endif + ]]) LIBS="$gl_saved_LIBS" ])