From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 386131F55B for ; Thu, 21 May 2020 15:22:50 +0000 (UTC) Received: from localhost ([::1]:42428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbn21-00033r-1w for normalperson@yhbt.net; Thu, 21 May 2020 11:22:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbn1t-00033j-9E for bug-gnulib@gnu.org; Thu, 21 May 2020 11:22:41 -0400 Received: from mo6-p01-ob.smtp.rzone.de ([2a01:238:20a:202:5301::3]:20996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbn1r-0002rL-4L for bug-gnulib@gnu.org; Thu, 21 May 2020 11:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1590074554; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=JRDM6j3Ny9p/+M2RPzVqRP7Lv+uG/uq/ftRzFD6q5Nk=; b=qzeK9fAZc9C03wfbBye3tpnfTFuQwkVmqlUJnWkvYkhvz5L3TnA818/2F21EyTybGh HIWL3lUMJC8YNDvbOg3PTnFDmZPcb93/EVuTxWBaYq07rg2mZMR1mTq7XSRmOrGQzkwo JJiMsRQQXIdB6Vc/yfUyX9Cn1MRkuICtD5hIH8LcktSc1pEoY7NSOr0EEfdQviCwFddq x3+AGUGqJNJz1DRmiQcGCai2FIL/cRBvf+D0jJ8eFxdSzz1YoY01COse25GEpM5G4qeE qfkBx3/MaEY2eLW/Xi2f9du5HanPPZMPk1kkLuBwPTmnjEnC4UE8hMvtHj95kDqr6kzk AmBw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.7.0 DYNA|AUTH) with ESMTPSA id x0bd30w4LFMYCqR (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 21 May 2020 17:22:34 +0200 (CEST) From: Bruno Haible To: Tim =?ISO-8859-1?Q?R=FChsen?= Subject: Re: Fix sanitizer error in fchownat.m4 Date: Thu, 21 May 2020 17:22:33 +0200 Message-ID: <7399257.RPdOTc7G22@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-177-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <3816106.4I1b13x7fG@omega> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Received-SPF: none client-ip=2a01:238:20a:202:5301::3; envelope-from=bruno@clisp.org; helo=mo6-p01-ob.smtp.rzone.de X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Tim R=FChsen wrote: > configure:55268: checking whether fchownat works with AT_SYMLINK_NOFOLLOW > SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change > conftest.c:812:50 in > configure:55326: checking whether fchownat works with an empty file name > SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change > conftest.c:817:37 in This patch should fix it. 2020-05-21 Bruno Haible fchownat: Support clang -fsanitize=3Dimplicit-integer-sign-change better. Reported by Tim R=FChsen in . * m4/fchownat.m4 (gl_FUNC_FCHOWNAT_DEREF_BUG, gl_FUNC_FCHOWNAT_EMPTY_FILENAME_BUG): Cast -1 to uid_t or git_t, respectively. diff --git a/m4/fchownat.m4 b/m4/fchownat.m4 index cd5c301..0a5d637 100644 =2D-- a/m4/fchownat.m4 +++ b/m4/fchownat.m4 @@ -1,4 +1,4 @@ =2D# fchownat.m4 serial 5 +# fchownat.m4 serial 6 dnl Copyright (C) 2004-2020 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -64,7 +64,7 @@ AC_DEFUN([gl_FUNC_FCHOWNAT_DEREF_BUG], int main () { =2D return (fchownat (AT_FDCWD, "$gl_dangle", -1, getgid (), + return (fchownat (AT_FDCWD, "$gl_dangle", (uid_t)(-1), getgid (), AT_SYMLINK_NOFOLLOW) !=3D 0 && errno =3D=3D ENOENT); } @@ -98,7 +98,7 @@ AC_DEFUN([gl_FUNC_FCHOWNAT_EMPTY_FILENAME_BUG], fd =3D open ("conftestdir", O_RDONLY); if (fd < 0) return 3; =2D ret =3D fchownat (fd, "", -1, -1, 0); + ret =3D fchownat (fd, "", (uid_t)(-1), (gid_t)(-1), 0); close (fd); rmdir ("conftestdir"); return ret =3D=3D 0;