From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AECE81F4B4 for ; Thu, 21 Jan 2021 18:02:18 +0000 (UTC) Received: from localhost ([::1]:33616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2eHh-000411-FT for normalperson@yhbt.net; Thu, 21 Jan 2021 13:02:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2eHU-000408-8M for bug-gnulib@gnu.org; Thu, 21 Jan 2021 13:02:05 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:33419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2eHS-0001tA-5J for bug-gnulib@gnu.org; Thu, 21 Jan 2021 13:02:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1611252119; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:From: Subject:Sender; bh=XoDUjVoLpfQDVzV+2rdq2WfYDuqREqikKfsHr0sMdw8=; b=SJBApxYit6de2caaaoLjN4IJwvh+KoyTvz7drI8ePvS1rkkYB1o/2/5Ai2JCYwtdNp tmO6Q4cop5qEnfermgxZlZQ8v7kUhPxj53ICpUppeM7ij7xq18sAC2WwwCyov2QVX2rh o5STdHo42Io2ODbYFnZCtpDxjfzV3/Hib8GtEFeVCE0guWc4jwlDZ9p+PCLdoHfL7xIp f0AiGZnAGQuXddNDdvfkwIuJgjrpqmkjMyTg1c+EZdl3ld6w/MffJ475Xn6X4Jqu3eWX IQCdo+S9yqcYsCp1nevA4PSZQ/0gpcuxBiHy4BQiqh7jtIqVdQ7M9aYxabcLFih7YJC5 9tyA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqfyyvs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.12.1 DYNA|AUTH) with ESMTPSA id u0aa20x0LI1wGNa (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 21 Jan 2021 19:01:58 +0100 (CET) From: Bruno Haible To: Simon Josefsson Subject: Re: link dependencies Date: Thu, 21 Jan 2021 19:01:57 +0100 Message-ID: <7196089.E70L7gZszV@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-197-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <871reeqme9.fsf@latte.josefsson.org> References: <8735yvvp31.fsf@latte.josefsson.org> <7496840.xjiyzb4qgF@omega> <871reeqme9.fsf@latte.josefsson.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.163; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Simon Josefsson wrote: > > > > +Link: > > +$(LIB_GETRANDOM) > > + > > License: > > LGPLv2+ > > Is this part needed? The module depends on getrandom. Is it because > that is only a conditional dependency? > > > diff --git a/modules/crypto/gc-tests b/modules/crypto/gc-tests > > index 7b153d1..5a16ba3 100644 > > --- a/modules/crypto/gc-tests > > +++ b/modules/crypto/gc-tests > > @@ -8,4 +8,4 @@ configure.ac: > > Makefile.am: > > TESTS += test-gc > > check_PROGRAMS += test-gc > > -test_gc_LDADD = $(LDADD) @LIB_CRYPTO@ > > +test_gc_LDADD = $(LDADD) @LIB_CRYPTO@ $(LIB_GETRANDOM) In test_gc_LDADD, $(LIB_GETRANDOM) is needed, to avoid the link error on MSVC. The 'Link' section in the module description is only informative. Originally, we thought that it would be good to note, in the 'Link' section, only the immediate link dependencies of the module, and let the user use ./gnulib-tool --extract-recursive-link-directive MODULE for the rest. But in the past few years, it has turned out that this does not work well: As a user of a module, we don't look at the recursive dependencies closure any more (partly because this closure is so large, often). The user of a module looks at the module description _only_. And so, the 'Link' section needs to contain the recursive link directive. And when changing some module to use 'getrandom', all direct and indirect callers of this module must get $(LIB_GETRANDOM) added to their module descriptions. Note that we don't (yet) follow this rule strictly for $(LIBINTL) and $(LIBUNISTRING). But for more rarely used libraries like $(LIB_GETRANDOM) it's worth it. Bruno