bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
* test-stat-time fails on AFS?
@ 2022-12-12  9:07 Simon Josefsson via Gnulib discussion list
  2023-01-03  1:28 ` Paul Eggert
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Josefsson via Gnulib discussion list @ 2022-12-12  9:07 UTC (permalink / raw)
  To: bug-gnulib

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi.  We got a bug report about a gnulib self-test failure:

https://gitlab.com/oath-toolkit/oath-toolkit/-/issues/30

Summarizing, this is the failure:

test-stat-time.c:186: assertion 'statinfo[2].st_mtime < statinfo[1].st_ctime || (statinfo[2].st_mtime == statinfo[1].st_ctime && (get_stat_mtime_ns (&statinfo[2]) < get_stat_ctime_ns (&statinfo[1])))' failed

The user is building it on an AFS file system, which most likely
explains the failure (although that has to be confirmed).  While the
explanation may be that AFS is not providing POSIX-semantics for the
file system, I think failing a self-test for this reason is too strong:
it could print an error message, or SKIP the test.  Thoughts?

/Simon

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: test-stat-time fails on AFS?
  2022-12-12  9:07 test-stat-time fails on AFS? Simon Josefsson via Gnulib discussion list
@ 2023-01-03  1:28 ` Paul Eggert
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2023-01-03  1:28 UTC (permalink / raw)
  To: Simon Josefsson, bug-gnulib

On 2022-12-12 01:07, Simon Josefsson via Gnulib discussion list wrote:
> While the
> explanation may be that AFS is not providing POSIX-semantics for the
> file system, I think failing a self-test for this reason is too strong:
> it could print an error message, or SKIP the test.  Thoughts?

Since the nap () business in that test is a heuristic and there's a good 
chance it's stricter than what POSIX requires, this sounds OK to me.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-03  1:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12  9:07 test-stat-time fails on AFS? Simon Josefsson via Gnulib discussion list
2023-01-03  1:28 ` Paul Eggert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).