From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DA56F1F66F for ; Tue, 3 Nov 2020 14:17:11 +0000 (UTC) Received: from localhost ([::1]:39644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZx7W-0006SF-BB for normalperson@yhbt.net; Tue, 03 Nov 2020 09:17:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZwyq-0003u8-Fb for bug-gnulib@gnu.org; Tue, 03 Nov 2020 09:08:13 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:36870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZwym-00055y-8H for bug-gnulib@gnu.org; Tue, 03 Nov 2020 09:08:10 -0500 Received: by mail-wr1-x442.google.com with SMTP id w1so18745002wrm.4 for ; Tue, 03 Nov 2020 06:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hYooykSK163OMNJ6JW8PNxtHho50z+9aqx3vW9cvtHQ=; b=CSZjAc7MmOfdbzsrQYLTyaTS7EsX9ajVk7A5s34PXbxY5tvulfgZUi3/Y94gSBjR8d h+2QI/KcT0LI1DQtXf6H+30zeMbzM86ZAWjxnWLS07C+VhkWwIKKlyRhcI05jI9vTlKC cvTcYFYttodBVxDeLX+GVOeYH1aYLcZFH6iq8WojLR4BYyqjGx21xWl/cwCV6b1/sIpI sf4lQCVR9wKmbC2Ngd5xqRJiuyuU5hhj96ch73ewcjvJ6Lbfvv/hXjU37GiUGO4DbxmJ vPWYmHoHomdsvhRrPYx06/SGaZcrsWwPfA6fTUKbOa7byxbazrC0F27YCgT3srImQDEE VGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hYooykSK163OMNJ6JW8PNxtHho50z+9aqx3vW9cvtHQ=; b=VyQsNmpi3egUT0Hbzkue+hIzGxpaafEaszAbpZQae5L3md3xKDhrP9X5dPmAfMB7WW ZCsXWvKheLUJtwTtXcH/JH7WKJCcs1zKhfhFXwwXFoCpvy+1mRSvFuIXo+5/2bV7MgvL J+s6935YyvTBL98J/jM0jeN8Xv0vEFXCUTTlAs7zoeYMhbKiGr9fHFWA4ldm+S3h0SPg FoAxWEww0pzdqKwvPa4rJnRFVGIMSV3IEPck4migJtllbIFFlLOKuq//PRmGR649MNgT sF10R3KqtIfzKIHO8phkhbuFmzjq8qLAhYQVDJpomLPgnB3+9stabyb2/1fLRABXDBKp tp8A== X-Gm-Message-State: AOAM5313tKU9cgYQ2i7UNL/zVxj5A0dqxI7doa6K+8W5vKIIFW6XyQcY 3mIwXnK+rwpFHPbDCQ837GcyWMwKEWb+6auT X-Google-Smtp-Source: ABdhPJx9bxmYIgWLreGjj4At5ptPM2HefK7PSFGh5GoMjPw7ROjQL/wv9P0xDAIE3SaECdWTTJNsfQ== X-Received: by 2002:a5d:66c9:: with SMTP id k9mr28866061wrw.158.1604412483096; Tue, 03 Nov 2020 06:08:03 -0800 (PST) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with UTF8SMTPSA id u3sm3403282wme.0.2020.11.03.06.08.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2020 06:08:02 -0800 (PST) Subject: Re: [PATCH] mountlist: recognize more file system types as remote To: Kamil Dudka References: <20201027212315.86480-1-P@draigBrady.com> <2702655.Y6S9NjorxK@nbkamil> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <6e5f76f1-e958-68d3-db7b-3703ec36b506@draigBrady.com> Date: Tue, 3 Nov 2020 14:08:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <2702655.Y6S9NjorxK@nbkamil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=pixelbeat@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 03/11/2020 08:31, Kamil Dudka wrote: > On Tuesday, October 27, 2020 10:23:15 PM CET Pádraig Brady wrote: >> Sync "remote" file systems from stat.c in coreutils. >> Note we only consider file systems that do not use host:resource >> mount source. I.e. those that don't generally use a colon when >> mounting, as that case is already considered. Searching for >> " /etc/fstab" was informative for identifying these. >> The full list of "remote" file systems in coreutils is currently: >> acfs afs ceph cifs coda fhgfs fuseblk fusectl >> gfs gfs2 gpfs ibrix k-afs lustre novell nfs nfsd >> ocfs2 panfs prl_fs smb smb2 snfs vboxsf vmhgfs vxfs >> Note also we include virtual machine file systems, >> as though they may not be distributed to separate hosts, >> they're remote to the current kernel. >> >> * lib/mountlist.c (ME_REMOTE): Sync previously unconsidered >> "remote" file systems from stat.c in coreutils. > > Looks good to me. > > Kamil > >> --- >> ChangeLog | 7 +++++++ >> lib/mountlist.c | 11 ++++++++++- >> 2 files changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/ChangeLog b/ChangeLog >> index 4eb5bcb1d..41e284558 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,10 @@ >> +2020-10-27 Pádraig Brady >> + >> + mountlist: recognize more file system types as remote >> + >> + * lib/mountlist.c (ME_REMOTE): Sync previously unconsidered >> + "remote" file systems from stat.c in coreutils. >> + >> 2020-10-26 Paul Eggert >> >> sys_stat: update comments for S_IRWXUGO, S_IXUGO >> diff --git a/lib/mountlist.c b/lib/mountlist.c >> index ca1be63f2..8205c29bd 100644 >> --- a/lib/mountlist.c >> +++ b/lib/mountlist.c >> @@ -224,7 +224,7 @@ me_remote (char const *fs_name, char const *fs_type >> _GL_UNUSED) #ifndef ME_REMOTE >> /* A file system is "remote" if its Fs_name contains a ':' >> or if (it is of type (smbfs or cifs) and its Fs_name starts with '//') >> - or if it is of type (afs or auristorfs) >> + or if it is of any other of the listed types >> or Fs_name is equal to "-hosts" (used by autofs to mount remote fs). */ >> # define ME_REMOTE(Fs_name, Fs_type) \ >> (strchr (Fs_name, ':') != NULL \ >> @@ -233,8 +233,17 @@ me_remote (char const *fs_name, char const *fs_type >> _GL_UNUSED) && (strcmp (Fs_type, "smbfs") == 0 \ >> >> || strcmp (Fs_type, "smb3") == 0 \ >> || strcmp (Fs_type, "cifs") == 0)) \ >> >> + || strcmp (Fs_type, "acfs") == 0 \ >> >> || strcmp (Fs_type, "afs") == 0 \ >> >> + || strcmp (Fs_type, "coda") == 0 \ >> >> || strcmp (Fs_type, "auristorfs") == 0 \ >> >> + || strcmp (Fs_type, "fhgfs") == 0 \ >> + || strcmp (Fs_type, "gpfs") == 0 \ >> + || strcmp (Fs_type, "ibrix") == 0 \ >> + || strcmp (Fs_type, "ocfs2") == 0 \ >> + || strcmp (Fs_type, "prl_fs") == 0 \ >> + || strcmp (Fs_type, "vboxsf") == 0 \ >> + || strcmp (Fs_type, "vxfs") == 0 \ >> >> || strcmp ("-hosts", Fs_name) == 0) >> >> #endif Thanks for the review. Upon further consideration I'm reluctant to include the "VM" file systems here. I.e. vboxsf and prl_fs, as they do consume space on the local machine. I'll add a comment about those instead, and will push. cheers, Pádraig