From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4EA401F461 for ; Wed, 3 Jul 2019 07:08:41 +0000 (UTC) Received: from localhost ([::1]:33244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiZNf-0000NP-D4 for normalperson@yhbt.net; Wed, 03 Jul 2019 03:08:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57212) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiZNX-0000Lv-JE for bug-gnulib@gnu.org; Wed, 03 Jul 2019 03:08:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiZNU-0000nt-R6 for bug-gnulib@gnu.org; Wed, 03 Jul 2019 03:08:31 -0400 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]:46235) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiZNU-0000mH-1k for bug-gnulib@gnu.org; Wed, 03 Jul 2019 03:08:28 -0400 Received: by mail-lj1-x241.google.com with SMTP id v24so1158912ljg.13 for ; Wed, 03 Jul 2019 00:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=frbigkzl+7nBY3VgJmmQvVg3tFn4yG7C+hHdpTuL+Z4=; b=bL93aOn/nNg+o1XsWqyPy51UGwC2p70D14mHE5yzQ4tH5g9FfCcQ32M7C+AC0yZrj9 KP3F7pYlBCD1wOd5OHzo2wL6xSGoYmK4Unfl23yVuirbjpXerfpYksY4+qW1CrtOO7VZ nAO2OwNvlo4z9VAHbYdKvLQaH7uC/QylJydoVmrgr1oDyLb6g70oxq556v1JEtixRGtx 9e8IE/KOmEb+YA4TvjlByrNi7nODaWvqJWoZYVaQO5JTfohVJeiuQmSFMf45S2wEQ5Wo iTI/HpeAY23o0pa/5tywcztgyCa2S5aDIPARMM+XYkNa/JM/tGBirbN9MHIEsx4dys0u KUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=frbigkzl+7nBY3VgJmmQvVg3tFn4yG7C+hHdpTuL+Z4=; b=gKZFjYyZdphkWOVXFLjhbAMRI0i+4uc+Wg5haGTwoVk8gScAuer8GrJL+k7wF7GMHX lkfWNOSDJM5MPtEBJWub2CNPvJ7ckAGJB3TXNqweQVBivchIbeWu1Za1UtTsYqCVSEK6 JsXGGBN0SbF52Zwkbo32d8Xp1/pAl+N7fVn4u04Nx0rsWvZMlautZRcVZVFWwbghhHXl D1Y1aFCg9NnD53rsl0+L4AN3QvBvDoxu9vzYXFtit+FmZ83LKar1W0hvnSbo/MWqDYwH YB9vVO6/kPEYY5Rg5joCxtztRIAWvE0qdRKD83eDnJf1+ytpJIeLyfz6E4IEgMWABrU6 jNcg== X-Gm-Message-State: APjAAAUJ/tFLmlEui/L+yEMxoLiLdOsdOV4Vdi6rfg3ZjMBrrhsnv8wN 4hwGtnrbqfO4SZqrDTLZQi3IwXpR X-Google-Smtp-Source: APXvYqxIiKzdThqUofW0vPvQY3UX6tEb1qwjr6pqgty4FqaUYVKq6GMfSqSPYfto5mXZc1qmr5iOtg== X-Received: by 2002:a2e:80d6:: with SMTP id r22mr20025412ljg.83.1562137705343; Wed, 03 Jul 2019 00:08:25 -0700 (PDT) Received: from [10.0.0.10] (ti0040q160-0589.bb.online.no. [109.189.153.84]) by smtp.gmail.com with ESMTPSA id s24sm296557lje.58.2019.07.03.00.08.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jul 2019 00:08:24 -0700 (PDT) From: Gisle Vanem Subject: Re: getaddrinfo tests: fix test failure on MSVC To: bug-gnulib@gnu.org References: <45970095.fu9pO4Vmgl@omega> Message-ID: <6b0d4974-66e7-97f6-4548-310b9460a007@gmail.com> Date: Wed, 3 Jul 2019 09:08:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <45970095.fu9pO4Vmgl@omega> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::241 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Bruno Haible wrote: > On native Windows with MSVC, I observe this test failure: > > FAIL: test-getaddrinfo > ====================== > > FAIL test-getaddrinfo.exe (exit status: 4) > > The cause is a missing call to WSAStartup(). This patch fixes it. I found the same problem with test-select-fd.c: --- a/tests/test-select-fd.c 2019-01-02 12:05:09 +++ b/tests/test-select-fd.c 2019-07-03 06:48:11 @@ -21,6 +21,7 @@ #include #include #include +#include int main (int argc, char *argv[]) @@ -44,6 +45,7 @@ struct timeval timeout; int ret; + gl_sockets_startup (SOCKETS_1_1); FD_ZERO (&fds); FD_SET (fd, &fds); timeout.tv_sec = 0; -- --gv