bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: [PATCH] Avoid having GNULIB_NAMESPACE::func always inject references to rpl_func
Date: Mon, 21 Nov 2016 20:24:43 +0000	[thread overview]
Message-ID: <669d9dd4-6794-f900-1ff8-64577b961843@redhat.com> (raw)
In-Reply-To: <4455007.neO9shxJ08@linuix.haible.de>

On 11/20/2016 12:26 PM, Bruno Haible wrote:
> Hi Pedro,

Hi!

> I added ChangeLog entries for your two patches from 2016-11-12
> (that Paul committed).

Thanks!  Should I assume you're all using git-merge-changelog and
include ChangeLog changes in the diff as well as in the
commit log?

> The member function 'rpl ()' is not used, other than in the 'operator type'.
> How about inlining and eliminating it?

That's fine with me.
                                  \
>      _GL_EXTERN_C int _gl_cxxalias_dummy
> @@ -234,11 +228,7 @@
>        static const struct _gl_ ## func ## _wrapper                            \
>        {                                                                       \
>          typedef rettype (*type) parameters;                                   \
> -                                                                              \
> -        inline type rpl () const                                              \
> -        { return reinterpret_cast<type>((rettype2 (*) parameters2)(::func)); }\
> -                                                                              \
> -        inline operator type () const { return rpl (); }                      \
> +        inline operator type () const { return reinterpret_cast<type>((rettype2 (*) parameters2)(::func)); } \

How about breaking this line like the rpl method was breaking it, in order
to avoid overly-long lines?

           inline operator type () const
           { return reinterpret_cast<type>((rettype2 (*) parameters2)(::func)); }

Likewise the other similar cases.

Thanks,
Pedro Alves



  reply	other threads:[~2016-11-21 20:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-12 16:22 [PATCH] Avoid having GNULIB_NAMESPACE::func always inject references to rpl_func Pedro Alves
2016-11-12 17:30 ` Paul Eggert
2016-11-14 18:16   ` [PATCH] Fix real-floating argument functions in C++ mode Pedro Alves
2016-11-14 21:19     ` Pedro Alves
2016-11-14 23:08       ` Pedro Alves
2016-11-15 17:17         ` Paul Eggert
2016-11-20 12:26 ` [PATCH] Avoid having GNULIB_NAMESPACE::func always inject references to rpl_func Bruno Haible
2016-11-21 20:24   ` Pedro Alves [this message]
2016-11-21 23:27     ` Bruno Haible
2016-11-21 23:33       ` Pedro Alves
2016-11-21 23:34     ` ChangeLog entries Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=669d9dd4-6794-f900-1ff8-64577b961843@redhat.com \
    --to=palves@redhat.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).