_FILE_OFFSET_BITS problem on Solaris 10 due to new stdbool.h handling

_FILE_OFFSET_BITS problem on Solaris 10 due to new stdbool.h handling

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

I ran into a problem on Solaris 10 gcc when building bleeding-edge grep 
and installed the attached into Gnulib to fix it.

[-- Attachment #2: stackvma.patch --]
[-- Type: text/x-patch, Size: 2687 bytes --]

diff --git a/ChangeLog b/ChangeLog
index d474155df7..61107c67fa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2023-01-22  Paul Eggert  <eggert@cs.ucla.edu>
+
+	sigsegv, vma-iter: port to Solaris 10
+	On this platform, <sys/types.h> does not define off_t if neither
+	_LP64 nor _FILE_OFFSET_BITS is defined, which can happen if we
+	#undef _FILE_OFFSET_BITS.  This became a problem with the new way
+	of doing stdbool, since config.h now includes <stdbool.h>, and
+	Solaris 10 <stdbool.h> includes <sys/feature_tests.h> which
+	arranges for _FILE_OFFSET_BITS to always be defined (if only to 32),
+	which <sys/types.h> assumes.
+	* lib/stackvma.c, lib/vma-iter.c (_FILE_OFFSET_BITS) [__sun && !_LP64]:
+	Define to 32 instead of leaving undefined.
+
 2023-01-21  Bruno Haible  <bruno@clisp.org>
 
 	login_tty: Ensure declaration in <utmp.h>.
diff --git a/lib/stackvma.c b/lib/stackvma.c
index 4408ca8e15..1224b7b07c 100644
--- a/lib/stackvma.c
+++ b/lib/stackvma.c
@@ -22,6 +22,7 @@
 /* On Solaris in 32-bit mode, when gnulib module 'largefile' is in use,
    prevent a compilation error
      "Cannot use procfs in the large file compilation environment"
+   while also preventing <sys/types.h> from not defining off_t.
    On Android, when targeting Android 4.4 or older with a GCC toolchain,
    prevent a compilation error
      "error: call to 'mmap' declared with attribute error: mmap is not
@@ -30,7 +31,11 @@
       switch to Clang."
    The files that we access in this compilation unit are less than 2 GB
    large.  */
-#if defined __sun || defined __ANDROID__
+#if defined __sun && !defined _LP64 && _FILE_OFFSET_BITS == 64
+# undef _FILE_OFFSET_BITS
+# define _FILE_OFFSET_BITS 32
+#endif
+#ifdef __ANDROID__
 # undef _FILE_OFFSET_BITS
 #endif
 
diff --git a/lib/vma-iter.c b/lib/vma-iter.c
index ccb221d273..2584d5ec34 100644
--- a/lib/vma-iter.c
+++ b/lib/vma-iter.c
@@ -20,6 +20,7 @@
 /* On Solaris in 32-bit mode, when gnulib module 'largefile' is in use,
    prevent a compilation error
      "Cannot use procfs in the large file compilation environment"
+   while also preventing <sys/types.h> from not defining off_t.
    On Android, when targeting Android 4.4 or older with a GCC toolchain,
    prevent a compilation error
      "error: call to 'mmap' declared with attribute error: mmap is not
@@ -28,7 +29,11 @@
       switch to Clang."
    The files that we access in this compilation unit are less than 2 GB
    large.  */
-#if defined __sun || defined __ANDROID__
+#if defined __sun && !defined _LP64 && _FILE_OFFSET_BITS == 64
+# undef _FILE_OFFSET_BITS
+# define _FILE_OFFSET_BITS 32
+#endif
+#ifdef __ANDROID__
 # undef _FILE_OFFSET_BITS
 #endif
 

Re: _FILE_OFFSET_BITS problem on Solaris 10 due to new stdbool.h handling

[Bruno Haible]

Paul Eggert wrote:
> I ran into a problem on Solaris 10 gcc

Thanks. I reproduce it on Solaris 10, 32-bit mode, with cc but not with gcc:

  cc -D_STDC_C99= -O -DHAVE_CONFIG_H -I. -I../../gllib -I..  -DGNULIB_STRICT_CHECKING=1  -I/home/haible/prefix-x86/include -D_REENTRANT  -g -c -o stackvma.o ../../gllib/stackvma.c
  "/usr/include/stdio.h", line 321: syntax error before or at: off_t

In GNU libsigsegv, there is nothing to do because libsigsegv does not set
_FILE_OFFSET_BITS=64. But for 'grep', evidently, it is important to be able
to access files larger than 2 GB.

I propagated the fix to the two stable branches.

Bruno

Re: _FILE_OFFSET_BITS problem on Solaris 10 due to new stdbool.h handling

[Paul Eggert]

On 1/22/23 02:39, Bruno Haible wrote:
> Thanks. I reproduce it on Solaris 10, 32-bit mode, with cc but not with gcc:
Yes, I think it may depend on GCC version. I observed it with gcc (GCC) 
3.4.3 (csl-sol210-3_4-branch+sol_rpath) which is shipped with Solaris 10 
sparc.