From: "Tim Rühsen" <tim.ruehsen@gmx.de>
To: Akim Demaille <akim.demaille@gmail.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>, Gnulib bugs <bug-gnulib@gnu.org>
Subject: Re: maintainer-makefile: catch uses of $< in non-implicit rules
Date: Tue, 25 Jun 2019 15:12:49 +0200 [thread overview]
Message-ID: <65427040-1430-6324-00ea-0b8d0fa3a57e@gmx.de> (raw)
In-Reply-To: <75B6A874-75A5-41CD-95E9-DC5938062CF3@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 3572 bytes --]
Hi Akim,
On 6/24/19 5:56 PM, Akim Demaille wrote:
> Hi Tim,
>
>> Le 24 juin 2019 à 11:42, Tim Rühsen <tim.ruehsen@gmx.de> a écrit :
>>
>> Hi Akim,
>>
>> Your proposal works here on Debian after I switched to mawk via
>> 'update-alternatives --config awk', selecting mawk. It detects two
>> occurrences of $< in our (project) Makefiles correctly.
>>
>> Switching back to the old maint.mk, brings back the error message about
>> '-e'. I just did this to make sure.
>
> Perfect, thanks. Installed.
I updated gnulib to your commit
(47405621b3066c035b4b98d2db934d550aaed1ad) and - sorry to say - two CI
runners broke. That are Arch Linux and Fedora 30.
Output on Fedora 30 from 'make syntax-check':
prohibit_gnu_make_extensions
Error: lib/Makefile: $< in a non implicit rule
# makefile (from 'lib/Makefile', line 1310)
NEXT_STRING_H = <string.h>
# makefile (from 'lib/Makefile', line 1409)
REPLACE_LOCALECONV = 0
# makefile (from 'lib/Makefile', line 1231)
LTLIBICONV =
# makefile (from 'lib/Makefile', line 476)
ETAGS = etags
# environment
halt =
# makefile (from 'lib/Makefile', line 1450)
REPLACE_PTSNAME = 0
# automatic
?F = $(notdir $?)
# makefile (from 'lib/Makefile', line 784)
GNULIB_STRTOD = 0
# makefile (from 'lib/Makefile', line 1410)
REPLACE_LOCALTIME = 0
... (many more lines like these) ...
MAKE_VERSION := 4.2.1
# makefile (from 'lib/Makefile', line 540)
GNULIB_ATOLL = 0
# variable set hash-table stats:
# Load=1368/2048=67%, Rehash=1, Collisions=6067/4772=127%
Error: lib/Makefile: $< in a non implicit rule
%.lo: %.c
# recipe to execute (from 'lib/Makefile', line 2150):
$(AM_V_CC)depbase=`echo $@ | sed
's|[^/]*$$|$(DEPDIR)/&|;s|\.lo$$||'`;\
$(LTCOMPILE) -MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@ $< &&\
$(am__mv) $$depbase.Tpo $$depbase.Plo
Error: lib/Makefile: $< in a non implicit rule
%.o: %.c
# recipe to execute (from 'lib/Makefile', line 2134):
$(AM_V_CC)depbase=`echo $@ | sed
's|[^/]*$$|$(DEPDIR)/&|;s|\.o$$||'`;\
$(COMPILE) -MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@ $< &&\
$(am__mv) $$depbase.Tpo $$depbase.Po
Error: lib/Makefile: $< in a non implicit rule
%.obj: %.c
# recipe to execute (from 'lib/Makefile', line 2142):
$(AM_V_CC)depbase=`echo $@ | sed
's|[^/]*$$|$(DEPDIR)/&|;s|\.obj$$||'`;\
$(COMPILE) -MT $@ -MD -MP -MF $$depbase.Tpo -c -o $@
`$(CYGPATH_W) '$<'` &&\
$(am__mv) $$depbase.Tpo $$depbase.Po
Error: lib/Makefile: $< in a non implicit rule
(%): %
# recipe to execute (built-in):
$(AR) $(ARFLAGS) $@ $<
Error: lib/Makefile: $< in a non implicit rule
%.out: %
# recipe to execute (built-in):
@rm -f $@
cp $< $@
Error: lib/Makefile: $< in a non implicit rule
%:: s.%
# recipe to execute (built-in):
$(GET) $(GFLAGS) $(SCCS_OUTPUT_OPTION) $<
Error: lib/Makefile: $< in a non implicit rule
%:: SCCS/s.%
# recipe to execute (built-in):
$(GET) $(GFLAGS) $(SCCS_OUTPUT_OPTION) $<
make: *** [maint.mk:439: sc_prohibit_gnu_make_extensions] Error 1
[root@61f4306ca485 wget2]# cd gnulib
[root@61f4306ca485 gnulib]# git branch
* (HEAD detached at 47405621b)
master
[root@61f4306ca485 gnulib]# git log
commit 47405621b3066c035b4b98d2db934d550aaed1ad (HEAD, origin/master,
origin/HEAD, master)
Author: Akim Demaille <akim.demaille@gmail.com>
Date: Tue Jun 25 08:11:34 2019 +0200
[root@61f4306ca485 gnulib]# awk --version
GNU Awk 4.2.1, API: 2.0 (GNU MPFR 3.1.6-p2, GNU MP 6.1.2)
Regards, Tim
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-25 13:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 7:44 maintainer-makefile: catch uses of $< in non-implicit rules Akim Demaille
2019-05-18 7:52 ` Paul Eggert
2019-05-18 9:51 ` Akim Demaille
2019-05-18 18:21 ` Paul Eggert
2019-05-19 5:42 ` Akim Demaille
2019-06-17 9:57 ` Tim Rühsen
2019-06-17 9:59 ` Akim Demaille
2019-06-17 10:04 ` Tim Rühsen
2019-06-22 15:53 ` Akim Demaille
2019-06-24 9:42 ` Tim Rühsen
2019-06-24 15:56 ` Akim Demaille
2019-06-25 13:12 ` Tim Rühsen [this message]
2019-06-25 13:24 ` Tim Rühsen
2019-06-25 14:37 ` Bruno Haible
2019-06-25 14:39 ` Tim Rühsen
2019-06-25 14:46 ` Tim Rühsen
2019-07-10 9:07 ` Tim Rühsen
2019-07-10 9:38 ` Tim Rühsen
2019-07-10 10:21 ` Tim Rühsen
2019-07-10 19:32 ` Akim Demaille
2019-07-11 8:00 ` Tim Rühsen
2019-07-11 8:46 ` Tim Rühsen
2019-07-19 7:40 ` Bernhard Voelker
2019-07-19 7:30 ` Bernhard Voelker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65427040-1430-6324-00ea-0b8d0fa3a57e@gmx.de \
--to=tim.ruehsen@gmx.de \
--cc=akim.demaille@gmail.com \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).