From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: Re: [PATCH] test-canonicalize: avoid a build failure
Date: Tue, 04 Feb 2020 03:15:59 +0100 [thread overview]
Message-ID: <6352571.oCA3OiAfF8@omega> (raw)
In-Reply-To: <20200204010434.301261-1-P@draigBrady.com>
> + * tests/test-canonicalize.c: Protect the inclusion of null-ptr.h
> + with the same guard as that used to protect usage of the null_ptr
> + function
The patch is OK.
However, I would appreciate if you don't call a warning a "build failure"
or an "error".
Reasons:
1. Adding -Werror to the CFLAGS is under the responsibility of the package
and/or person who builds the package. Gnulib does not add -Werror.
2. For this reason, someone who builds the package has a much easier
fix/workaround -- namely, just remove '-Werror' in one or two places in
the Makefiles -- than when there is e.g. a syntax error or a link error.
3. Gnulib does not and can not guarantee warning-free compilation, because
there are so many platforms, so many compiler warning options, and
sometimes even false positives among the warnings.
All that Gnulib guarantees is an error-free compilation *without* -Werror.
Bruno
next prev parent reply other threads:[~2020-02-04 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 1:04 [PATCH] test-canonicalize: avoid a build failure Pádraig Brady
2020-02-04 2:15 ` Bruno Haible [this message]
2020-02-11 2:27 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6352571.oCA3OiAfF8@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).