bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Collin Funk <collin.funk1@gmail.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Cc: Jim Meyering <jim@meyering.net>
Subject: Re: syntax-check rule to silence -Winclude-next-absolute-path warning
Date: Tue, 20 Feb 2024 12:23:33 -0800	[thread overview]
Message-ID: <62b86835-da5c-479b-863a-1fb83382d16f@gmail.com> (raw)
In-Reply-To: <45004650.doPnVEEUbh@nimes>

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

On 2/18/24 4:44 AM, Bruno Haible wrote:
> The full list of header files for which #include "..." is to be avoided is:
> 
> alloca.h
> arpa_inet.h
> assert.h

I saw that arpa_inet.h had an underscore instead of a slash in this
message but forgot to fix it when I pasted it into the Makefile... Sorry
about that. I attached the fix.

Collin

[-- Attachment #2: 0001-maint.mk-Fix-include-header-typo.patch --]
[-- Type: text/x-patch, Size: 1038 bytes --]

From 1f526466d4a2c54ea227e438c12127fc305c2a43 Mon Sep 17 00:00:00 2001
From: Collin Funk <collin.funk1@gmail.com>
Date: Tue, 20 Feb 2024 12:16:40 -0800
Subject: [PATCH] maint.mk: Fix include header typo.

top/maint.mk: Change arpa_inet.h to arpa/inet.h.
---
 ChangeLog    | 5 +++++
 top/maint.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index ef069e2e94..32985d0abb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2024-02-20  Collin Funk  <collin.funk1@gmail.com>
+
+	maint.mk: Fix include header typo.
+	* top/maint.mk: Change arpa_inet.h to arpa/inet.h.
+
 2024-02-20  Bruno Haible  <bruno@clisp.org>
 
 	*printf-posix: Avoid crash in a configure test.
diff --git a/top/maint.mk b/top/maint.mk
index 2278619931..c30e71ba6e 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -541,7 +541,7 @@ sc_require_config_h_first:
 # Keep sorted.
 gl_prefer_angle_bracket_headers_ ?= \
   alloca.h		\
-  arpa_inet.h		\
+  arpa/inet.h		\
   assert.h		\
   ctype.h		\
   dirent.h		\
-- 
2.39.2


  parent reply	other threads:[~2024-02-20 20:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17  8:36 [PATCH] math: Silence -Winclude-next-absolute-path warning Collin Funk
2024-02-17 10:51 ` Bruno Haible
2024-02-17 12:26   ` Collin Funk
2024-02-17 13:17     ` Bruno Haible
2024-02-18 12:19     ` Bruno Haible
2024-02-18 12:44       ` syntax-check rule to silence " Bruno Haible
2024-02-18 20:12         ` Collin Funk
2024-02-18 20:33           ` Bruno Haible
2024-02-19  5:02             ` Jim Meyering
2024-02-19 18:11               ` Collin Funk
2024-02-19 18:32                 ` Jim Meyering
2024-02-19  8:45             ` Simon Josefsson via Gnulib discussion list
2024-02-19 20:39               ` Jim Meyering
2024-02-20 15:17               ` Bruno Haible
2024-02-20 20:23         ` Collin Funk [this message]
2024-02-20 20:49           ` Bruno Haible
2024-02-19  6:31       ` [PATCH] math: Silence " Paul Eggert
2024-02-19 11:03         ` Bruno Haible
2024-02-19 20:41           ` Paul Eggert
2024-02-19 21:24             ` Bruno Haible
2024-02-19 21:45               ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62b86835-da5c-479b-863a-1fb83382d16f@gmail.com \
    --to=collin.funk1@gmail.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=jim@meyering.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).