From: Paul Eggert <eggert@cs.ucla.edu>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: explicit_bzero-tests: pacify -Wmissing-declarations
Date: Thu, 28 May 2020 16:04:07 -0700 [thread overview]
Message-ID: <6210b975-1c36-59d3-c5ab-5c34cd13dc2f@cs.ucla.edu> (raw)
In-Reply-To: <8555737.hM7WduKNvG@omega>
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
On 5/28/20 3:24 PM, Bruno Haible wrote:
> Agreed. Please go ahead. I'll deal with possible xlc/Sun cc/MSVC build failures
> then.
OK, I installed the attached.
[-- Attachment #2: 0001-explicit_bzero-tests-improve-Wmissing-declarations-p.patch --]
[-- Type: text/x-patch, Size: 1486 bytes --]
From ef7cc081f5c0d1b71f60f71d5e0f4a9ddf76bb28 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 28 May 2020 16:02:32 -0700
Subject: [PATCH] explicit_bzero-tests: improve -Wmissing-declarations
pacification
* tests/test-explicit_bzero.c: Now noinline.
Suggested by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2020-05/msg00300.html
---
ChangeLog | 7 +++++++
tests/test-explicit_bzero.c | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 602923d3f..0a62f572d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2020-05-28 Paul Eggert <eggert@cs.ucla.edu>
+
+ explicit_bzero-tests: improve -Wmissing-declarations pacification
+ * tests/test-explicit_bzero.c: Now noinline.
+ Suggested by Bruno Haible in:
+ https://lists.gnu.org/r/bug-gnulib/2020-05/msg00300.html
+
2020-05-28 Bruno Haible <bruno@clisp.org>
Fix build errors due to read-file changes (regression from 2020-05-27).
diff --git a/tests/test-explicit_bzero.c b/tests/test-explicit_bzero.c
index 385fd12a9..b5698f898 100644
--- a/tests/test-explicit_bzero.c
+++ b/tests/test-explicit_bzero.c
@@ -128,7 +128,7 @@ test_heap (void)
2. Verify that the memory has been erased.
Implement them in the same function, so that they access the same memory
range on the stack. */
-static int
+static int _GL_ATTRIBUTE_NOINLINE
do_secret_stuff (volatile int pass)
{
char stackbuf[SECRET_SIZE];
--
2.26.1
prev parent reply other threads:[~2020-05-28 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 7:28 explicit_bzero-tests: pacify -Wmissing-declarations Bruno Haible
2020-05-28 22:11 ` Paul Eggert
2020-05-28 22:24 ` Bruno Haible
2020-05-28 23:04 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6210b975-1c36-59d3-c5ab-5c34cd13dc2f@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).