bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / code / Atom feed
* pipe-filter-ii tests: Fix long-standing failure on native Windows
@ 2021-06-15 16:38 Bruno Haible
  0 siblings, 0 replies; only message in thread
From: Bruno Haible @ 2021-06-15 16:38 UTC (permalink / raw)
  To: bug-gnulib

The test-pipe-filter-ii2.sh test never worked on native Windows, due
to CR-LF and even CR-CR-LF seequences in the output.


2021-06-15  Bruno Haible  <bruno@clisp.org>

	pipe-filter-ii tests: Fix long-standing failure on native Windows.
	* tests/test-pipe-filter-ii2-main.c: Include binary-io.h.
	(main): Avoid NL to CRLF conversion on standard output.
	* tests/test-pipe-filter-ii2-child.c: Include <unistd.h>, binary-io.h.
	(main): Avoid NL to CRLF conversion on standard output.

diff --git a/tests/test-pipe-filter-ii2-child.c b/tests/test-pipe-filter-ii2-child.c
index 14c9863..2610988 100644
--- a/tests/test-pipe-filter-ii2-child.c
+++ b/tests/test-pipe-filter-ii2-child.c
@@ -20,10 +20,15 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <unistd.h>
+
+#include "binary-io.h"
 
 int
 main ()
 {
+  set_binary_mode (STDOUT_FILENO, O_BINARY);
+
   /* Repeatedly: Read two integers i and j, then output all integers in the
      range i..j, one per line.  */
   for (;;)
diff --git a/tests/test-pipe-filter-ii2-main.c b/tests/test-pipe-filter-ii2-main.c
index 3674e01..aad0505 100644
--- a/tests/test-pipe-filter-ii2-main.c
+++ b/tests/test-pipe-filter-ii2-main.c
@@ -26,6 +26,7 @@
 #include <string.h>
 #include <signal.h>
 
+#include "binary-io.h"
 #include "full-write.h"
 #include "macros.h"
 
@@ -88,6 +89,8 @@ main (int argc, char **argv)
 
   ASSERT (argc == 2);
 
+  set_binary_mode (STDOUT_FILENO, O_BINARY);
+
   /* Test writing to a nonexistent program traps sooner or later.  */
   {
     struct locals l;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-15 16:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 16:38 pipe-filter-ii tests: Fix long-standing failure on native Windows Bruno Haible

Code repositories for project(s) associated with this inbox:

	../../../mirrors/gnulib.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).