From: KO Myung-Hun <komh78@gmail.com>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH 5/7] zerosize-ptr: Fix compilation on OS/2 kLIBC
Date: Fri, 22 Jan 2021 23:26:37 +0900 [thread overview]
Message-ID: <600AE09D.4070609@gmail.com> (raw)
In-Reply-To: <2470197.9hkJXdE0Ak@omega>
Hi/2.
Bruno Haible wrote:
> Applied with modifications:
>> -#if HAVE_SYS_MMAN_H && HAVE_MPROTECT
>> +#if HAVE_SYS_MMAN_H && HAVE_MPROTECT && (!defined __KLIBC__ || HAVE_MMAP)
>
> There's a comment two lines above, that explains why HAVE_MMAP is not
> the right test here. And since you write "OS/2 kLIBC has <sys/mman.h>
> and mprotect() but not mmap()", defined __KLIBC__ implies !HAVE_MMAP.
>
I saw that. So I tested HAVE_MMAP only on kLIBC. Anyway I agree that
just defined __KLIBC__ is enough.
Thanks!
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.os2.kr/
next prev parent reply other threads:[~2021-01-22 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 16:40 [PATCH 1/7] spawn: Use special invocation for <spawn.h> on OS/2 kLIBC KO Myung-Hun
2021-01-18 16:40 ` [PATCH 2/7] yield: Fix linkage to threadlib " KO Myung-Hun
2021-01-18 16:40 ` [PATCH 3/7] stddef: Fix compilation for max_align_t " KO Myung-Hun
2021-01-18 16:40 ` [PATCH 4/7] stdlib: putenv() needs a cast " KO Myung-Hun
2021-01-19 17:54 ` Bruno Haible
2021-01-22 14:35 ` KO Myung-Hun
2021-01-31 8:32 ` KO Myung-Hun
2021-01-18 16:40 ` [PATCH 5/7] zerosize-ptr: Fix compilation " KO Myung-Hun
2021-01-19 18:10 ` Bruno Haible
2021-01-22 14:26 ` KO Myung-Hun [this message]
2021-01-18 16:40 ` [PATCH 6/7] dirent: Redefine dirfd macro as a rpl function always KO Myung-Hun
2021-01-18 16:40 ` [PATCH 7/7] spawn-pipe: Fix SIGSEGV on OS/2 kLIBC KO Myung-Hun
2021-01-19 18:28 ` [PATCH 1/7] spawn: Use special invocation for <spawn.h> " Bruno Haible
2021-01-22 14:37 ` KO Myung-Hun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600AE09D.4070609@gmail.com \
--to=komh78@gmail.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).