bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Collin Funk <collin.funk1@gmail.com>
To: bug-gnulib@gnu.org
Subject: Re: gnulib-tool.py: Fix extra arguments to function call.
Date: Sat, 13 Apr 2024 10:26:38 -0700	[thread overview]
Message-ID: <5ff55c46-aaf4-4311-9e01-49498aa69f08@gmail.com> (raw)
In-Reply-To: <af03edbd-8231-4c26-a0b1-ef6ebdb30dbe@gmail.com>

On 4/13/24 10:12 AM, Collin Funk wrote:
> diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py
> index d44ceedcec..098bbc59ac 100644
> --- a/pygnulib/GLImport.py
> +++ b/pygnulib/GLImport.py
> @@ -1230,7 +1230,7 @@ AC_DEFUN([%s_FILE_LIST], [\n''' % macro_prefix

Also, I found out that adding '*.py diff=python' to .gitattributes
will give a better diff hunk header [1]:

diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py
index d44ceedcec..098bbc59ac 100644
--- a/pygnulib/GLImport.py
+++ b/pygnulib/GLImport.py
@@ -1230,7 +1230,7 @@ def execute(self, filetable: dict[str, list[str]], transformers: dict[str, str])

[1] https://github.com/git/git/blob/8f7582d995682f785e80e344197cc715e6bc7d8e/userdiff.c#L270

Collin


  reply	other threads:[~2024-04-13 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13 17:12 gnulib-tool.py: Fix extra arguments to function call Collin Funk
2024-04-13 17:26 ` Collin Funk [this message]
2024-04-13 18:08   ` .gitattributes Bruno Haible
2024-04-13 18:18     ` Improve 'git diff' of Python files Collin Funk
2024-04-13 18:29       ` Bruno Haible
2024-04-13 18:03 ` gnulib-tool.py: Fix extra arguments to function call Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ff55c46-aaf4-4311-9e01-49498aa69f08@gmail.com \
    --to=collin.funk1@gmail.com \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).