From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5AF511F47C for ; Fri, 13 Jan 2023 08:50:45 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=fS9Ji2ws; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGFlh-0004d5-ID; Fri, 13 Jan 2023 03:50:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFlT-0004Vm-Nv for bug-gnulib@gnu.org; Fri, 13 Jan 2023 03:50:20 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFlR-0006TG-KW for bug-gnulib@gnu.org; Fri, 13 Jan 2023 03:50:19 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1673599811; cv=none; d=strato.com; s=strato-dkim-0002; b=QrsuL77CHqvNFex7NfpoV6ffQ1GHSNhEgDpkKVkPt9ijt43LDYqzQ4YDRuiWewO8ZT JuTC3hRW5wQvDUoq9GvkeDiDJp2PvYWaD0sYtmPcPkahN4O27YZrvXRjXiz7225t9S6V Zpr5Cy/JRYfiMl+F/g4jSR8OtK8OJRbs1Zgvgl+4bWxHI9OCrkvb8dCvGqmnT5ThQv+V hi4R0RuXES2OfeL7+3SJ2JnCJq749CJmsx57mPd7cNuEgi4kIP8nZuOOiBF5O1+4qnce eGcr9uz9HVmZ8tVPTN6RtDcEwQbdEuQknI4gZ/qVf9V8eBOqYZ+r+ifBJicrxgCyFmIj Hyfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1673599811; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=1LxZ3HzXpTXtobLC9ApLRja1Ms2Gv4KibUEKHRstlqs=; b=XL/wupElYIkKD36Gn7VCsV+sxldS2Ca2Xg/a5sgMb3l/una+St/svheEBtAXbXullz ioVq27NTXD43r0E63A2fPnrnDADy5Y9rdnEPWlkDA5UfPfi8pnakhdeuPEFEcfBDKYt1 kwsO9IxOaQOTmZMcKTM82MFfE5CzrCbqSqNE0QNx3zHdybfEzpOwUvDZlkIl+8GDnfds PXuJDLQpTa1Ec50DMKSDPNi6dhJ5GGfJEGHOOwvGyFjGxkVC4lsgeqZf8dLSYxJmRC72 UvgCRbqX6O4oQG5Cddq+KKDTevjGX935cLBQUzWmo3/xz8T8Pfwo0jeExxxDX69/N0NC rw0w== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1673599811; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=1LxZ3HzXpTXtobLC9ApLRja1Ms2Gv4KibUEKHRstlqs=; b=fS9Ji2wsq8aYWw4voo9jCZtZOuS8Tj67fgizIMBZMp2hYBjgr1PS2uPD0DBIoqoPEK kSzMXqQcIkp2QFPG0d/Ap1q3L9dF/ynFsQrLh9F0tC6cwxYahs3/eIcm/83yFw6gl6Tw R2adPwChZ3zmZ+vJwx47trpcSXyKarSMb9Tiq5dkH4mzCfjIAIyoboc8U8YWnoeVTKc/ /UShElawBIF2aHgoK6+GRzfLcsuMMT6tS+364b03pc63EZLFt5bzIIcd5VF783dvpfLp dZpMczniskB+2LOycTxmc/pHpVT6gdFLud9XpDZGEOSfIiNBYr0jCv0Yssm77KCTyGF6 8U/g== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOXjv2XTu3l95++Pe54Opj0GYzUnQ==" Received: from nimes.localnet by smtp.strato.de (RZmta 48.6.2 AUTH) with ESMTPSA id I8f358z0D8oBA8x (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 13 Jan 2023 09:50:11 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org, Ondrej Valousek Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c Date: Fri, 13 Jan 2023 09:50:10 +0100 Message-ID: <5709171.UesdLuknzO@nimes> In-Reply-To: <7698295.mr9Zh2SJbS@nimes> References: <20230104143425.1235741-1-ondrej.valousek.xm@renesas.com> <7698295.mr9Zh2SJbS@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.53; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org I wrote: > * modules/qcopy-acl (Depends-on): Add condition. > (configure.ac): Set QCOPY_ACL_LIB. > (Link): Add $(QCOPY_ACL_LIB). Remove $(LIB_ACL). Oops, this has a mistake. The variable LIB_ACL needs to be initialized before the code uses its value; otherwise $LIB_ACL will come out as empty. The way to order the initialization is to use AC_REQUIRE of the macro which defines LIB_ACL. Then, since invocation and AC_REQUIRE of a macro defined through AC_DEFUN triggers an autoconf warning, one needs AC_DEFUN_ONCE instead. 2023-01-13 Bruno Haible qcopy-acl: Make last patch more robust. * m4/acl.m4 (gl_FUNC_ACL): Define through AC_DEFUN_ONCE. * modules/qcopy-acl (configure.ac): Require gl_FUNC_ACL. diff --git a/m4/acl.m4 b/m4/acl.m4 index e612f1ae34..dc9853a156 100644 --- a/m4/acl.m4 +++ b/m4/acl.m4 @@ -1,5 +1,5 @@ # acl.m4 - check for access control list (ACL) primitives -# serial 26 +# serial 27 # Copyright (C) 2002, 2004-2023 Free Software Foundation, Inc. # This file is free software; the Free Software Foundation @@ -17,7 +17,7 @@ AC_DEFUN([gl_FUNC_ACL_ARG], ]) -AC_DEFUN([gl_FUNC_ACL], +AC_DEFUN_ONCE([gl_FUNC_ACL], [ AC_REQUIRE([gl_FUNC_ACL_ARG]) AC_CHECK_FUNCS_ONCE([fchmod]) diff --git a/modules/qcopy-acl b/modules/qcopy-acl index 8dd147927d..b89d8ecab6 100644 --- a/modules/qcopy-acl +++ b/modules/qcopy-acl @@ -10,6 +10,7 @@ acl-permissions [test "$use_xattr" != yes] configure.ac: gl_FUNC_XATTR +AC_REQUIRE([gl_FUNC_ACL]) if test "$use_xattr" = yes; then QCOPY_ACL_LIB="$LIB_XATTR" else