From: Paul Eggert <eggert@cs.ucla.edu>
To: "Daniel Richard G." <skunk@iSKUNK.ORG>, bug-gnulib@gnu.org
Subject: Re: [PATCH] IBM z/OS + EBCDIC support
Date: Tue, 22 Sep 2015 12:50:44 -0700 [thread overview]
Message-ID: <5601B114.4000409@cs.ucla.edu> (raw)
In-Reply-To: <1442888927.2328038.389926169.50DB0133@webmail.messagingengine.com>
A few non-ctype-related comments:
Omit parens around arguments of 'defined', e.g., say "defined __MVS__"
not "defined (__MVS__)".
I agree with Eric that we should rename "__string" rather than fiddle
with #undefing it. It's just a placeholder name. I suggest renaming it
to "__str". We can backport this to glibc eventually.
In strtod.c, don't bother with "if (errno == ERANGE) errno = 0;". Just
do "errno = 0;".
Also in strtod.c, don't assume isnand exists. That is, replace
"!isnand(num)" with "num == num".
Update serial numbers in changed .m4 files.
In m4/fclose.m4, gl_FUNC_FCLOSE should AC_REQUIRE([AC_CANONICAL_HOST]).
Also, it should test $host_os rather than $host.
In m4/strstr.m4, the __MVS__ failure should be at compile-time, with
#error, rather than at run-time. That's better if cross-compiling.
In comments, prefer imperatives, e.g., "Instead, temporarily redefine
..." rather than "Instead, we temporarily redefine ...". This is
standard GNU style and is shorter.
The get_rusage_as code has duplications. Simpler would be:
uintptr_t
get_rusage_as (void)
{
/* On Mac OS X, AIX, Cygwin, and z/OS, get_rusage_as_via_setrlimit
exists but does not work. */
#if (! ((defined __APPLE__ && defined __MACH__) \
|| defined _AIX || defined __CYGWIN__ || defined __MVS__) \
&& HAVE_SETRLIMIT && defined RLIMIT_AS && HAVE_SYS_MMAN_H &&
HAVE_MPROTECT)
/* Prefer get_rusage_as_via_setrlimit() if it succeeds,
because the caller may want to use the result with setrlimit(). */
uintptr_t result = get_rusage_as_via_setrlimit ();
if (result != 0)
return result;
#endif
return get_rusage_as_via_iterator ();
}
next prev parent reply other threads:[~2015-09-22 19:50 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 2:28 [PATCH] IBM z/OS + EBCDIC support Daniel Richard G.
2015-09-22 15:23 ` Eric Blake
2015-09-22 19:27 ` Daniel Richard G.
2015-09-22 20:00 ` Paul Eggert
2015-09-22 20:08 ` Eric Blake
2015-09-22 20:51 ` Daniel Richard G.
2015-09-22 19:32 ` Paul Eggert
2015-09-22 19:46 ` Paul Eggert
2015-09-22 20:37 ` Daniel Richard G.
2015-09-22 22:03 ` Paul Eggert
2015-09-22 23:44 ` Daniel Richard G.
2015-09-23 2:02 ` Paul Eggert
2015-09-23 6:58 ` Daniel Richard G.
2015-09-23 19:05 ` Paul Eggert
2015-09-23 19:29 ` Paul Eggert
2015-09-23 21:57 ` Daniel Richard G.
2015-09-25 7:29 ` Paul Eggert
2015-09-26 0:25 ` Daniel Richard G.
2015-09-26 2:49 ` Paul Eggert
2015-09-26 4:39 ` Daniel Richard G.
2015-09-26 16:08 ` Ben Pfaff
2015-09-27 6:31 ` Daniel Richard G.
2015-09-27 6:59 ` Paul Eggert
2015-09-28 2:09 ` Daniel Richard G.
2015-10-15 4:49 ` Daniel Richard G.
2016-08-18 0:47 ` Paul Eggert
2016-08-18 8:24 ` Daniel Richard G.
2016-08-18 8:53 ` Paul Eggert
2016-08-19 8:20 ` Daniel Richard G.
2016-08-19 11:03 ` Bruno Haible
2016-08-19 19:28 ` Paul Eggert
2016-08-19 20:38 ` Daniel Richard G.
2019-12-19 4:57 ` z/OS configure triple Bruno Haible
2019-12-20 0:22 ` Daniel Richard G.
2019-12-20 6:29 ` Bruno Haible
2019-12-19 5:16 ` z/OS, iconv, and charset aliases Bruno Haible
2019-12-19 5:21 ` Bruno Haible
2019-12-20 4:38 ` Daniel Richard G.
2019-12-20 8:19 ` Bruno Haible
2019-12-20 18:23 ` Daniel Richard G.
2019-12-21 5:49 ` z/OS, iconv, and gperf Bruno Haible
2020-01-09 5:48 ` Daniel Richard G.
2020-01-19 21:52 ` Bruno Haible
2020-01-19 21:59 ` Bruno Haible
2020-01-19 22:32 ` Daniel Richard G.
2020-01-20 0:13 ` Bruno Haible
2020-01-22 6:38 ` Daniel Richard G.
2015-09-22 19:50 ` Paul Eggert [this message]
2015-09-22 20:47 ` [PATCH] IBM z/OS + EBCDIC support Daniel Richard G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5601B114.4000409@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bug-gnulib@gnu.org \
--cc=skunk@iSKUNK.ORG \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).