From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 177181F698 for ; Sat, 31 Dec 2022 09:00:32 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.a=rsa-sha256 header.s=78364E5A-2AF3-11ED-87FA-8298ECA2D365 header.b=l7ZslVNA; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBXiu-0005bF-3x; Sat, 31 Dec 2022 04:00:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBXiq-0005am-7B for bug-gnulib@gnu.org; Sat, 31 Dec 2022 04:00:08 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBXio-0007tn-Ck for bug-gnulib@gnu.org; Sat, 31 Dec 2022 04:00:07 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D632E160041; Sat, 31 Dec 2022 01:00:03 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9LJXJ2VpYgEA; Sat, 31 Dec 2022 01:00:03 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0A671160064; Sat, 31 Dec 2022 01:00:03 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 0A671160064 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1672477203; bh=Xgx0Kf9kFu/i3ikgjTpKe5kFxuPYNwmxfgWUJSfyiFs=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding; b=l7ZslVNAgTnBe58CJXfQDznRd9LoQhWNNsh5/qW/xysqPPt9NpGPLszN8LJBg6iK4 Rv/WsArUvBxGSN1x8E3Kxlj+6+mmwFqC1I/ZfWvZnL3jNr0nX7XvDjcKX2Gu2LTPf1 Ni6xt7Ko055tdeTRA5N5VyHtPxnil+NSyePRqGMY= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BvwPa3ybhzCL; Sat, 31 Dec 2022 01:00:02 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CDEE2160041; Sat, 31 Dec 2022 01:00:02 -0800 (PST) Message-ID: <54db8d31-9d85-aa09-4113-0d403f83cacc@cs.ucla.edu> Date: Sat, 31 Dec 2022 01:00:02 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: Ondrej Valousek , bug-gnulib@gnu.org, kdudka@redhat.com References: <20221230091836.551445-1-ondrej.valousek.xm@renesas.com> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH] ACL handling simplification + support for NFSv4 In-Reply-To: <20221230091836.551445-1-ondrej.valousek.xm@renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.146, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org On 2022-12-30 01:18, Ondrej Valousek wrote: > * we no longer try to decode ACLs, instead we just copy the whole xattr with ACLs > making the code simpler and faster What happens if you try to copy ACLs from a filesystem using NFSv4 ACLs to one using POSIXish ACLs, or vice versa? > * it pulls in dependency on libattr (so needs to be linked with -lattr, the automake > changes are not yet included in this patch), but on the other way, we could possibly ditch > dependency on libacl. This would all have to be done, yes. > +#ifdef USE_XATTR > + ret = chmod_or_fchmod (dst_name, dest_desc, mode); Why is this call needed? Won't a successful attr_copy_file mean that the chmod_or_fchmod is unnecessary? I.e., can't we do the chmod_or_lchmod only if the attr_copy_file fails with a particular errno value that says "this file lacks extended attributes"? > + ret = source_desc <= 0 && dest_desc <= 0 > + ? attr_copy_file (src_name, dst_name, copy_attr_permissions, NULL) > + : attr_copy_fd (src_name, source_desc, dst_name, dest_desc, copy_attr_permissions, NULL); When these functions fail, what are their errno values and should we treat any of them specially? (I can't easily find documentation for these functions.)