From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 05AF41F61A for ; Sat, 10 Dec 2022 21:42:57 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.b="EjHieaMy"; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p47cM-0007fq-2U; Sat, 10 Dec 2022 16:42:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p47cH-0007ep-LK; Sat, 10 Dec 2022 16:42:42 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p47cF-00075M-DH; Sat, 10 Dec 2022 16:42:41 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 36C0916005C; Sat, 10 Dec 2022 13:42:35 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UTWq4Xa9ENK1; Sat, 10 Dec 2022 13:42:34 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6A6CF160066; Sat, 10 Dec 2022 13:42:34 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 6A6CF160066 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1670708554; bh=pfcAE0DMvLENPjJvztpSn+CS5RlVhyA7ebvqFvgdGhg=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type: Content-Transfer-Encoding; b=EjHieaMyW12Smcd+EDNAfCffBEBjPjo9bT+zfrs3z3Cz5vl7KNQuO+EeUj7J//8uQ 5FVGw74GypUKEGchsGRw3S35oav3Oiq/6WS2B0ee6flaJJZSi83vakBKvZhx/hgdo3 uwluzqDRf/iQpe3lZO+Mydh8NiHoNk+ypYbNruTY= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WOxA6_SMyqKL; Sat, 10 Dec 2022 13:42:34 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 13C3B16005C; Sat, 10 Dec 2022 13:42:34 -0800 (PST) Message-ID: <53b8b852-ebf3-b921-ca08-66748533ea51@cs.ucla.edu> Date: Sat, 10 Dec 2022 13:42:33 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: -Wlto-type-mismatch warning in error() Content-Language: en-US To: Gavin Smith , =?UTF-8?Q?Arsen_Arsenovi=c4=87?= , Eli Zaretskii , Bruno Haible , sam@gentoo.org, bug-texinfo@gnu.org, bug-gnulib@gnu.org References: <4989246.upeRZZJTqa@nimes> <831qpa4dyf.fsf@gnu.org> <86fsdqi87x.fsf@aarsen.me> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-0.288, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org On 2022-12-09 17:48, Gavin Smith wrote: >> Since I went through the process of making all the symbols in that file >> (besides main) local, here's the patch that does that > Thanks but no thanks. install-info.c is a single-file program so there's > no point in adding the static keyword everywhere. On the contrary, not only can adding 'static' prevent future issues like this with other symbols, it can help compilers generate better code in cases where adding 'static' lets them easily infer that a function cannot be called from outside the current compilation unit. As a general rule in C, it's good to make all symbols static unless they really need to be extern.