From: Bruno Haible <bruno@clisp.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org
Subject: Re: localtime on native Windows
Date: Sun, 18 Feb 2024 15:38:01 +0100 [thread overview]
Message-ID: <5188612.NACDBdzCOe@nimes> (raw)
In-Reply-To: <20badeaa-befb-4f35-b479-c0cf1397ff04@cs.ucla.edu>
Paul Eggert wrote:
> > Note also: The above approach will need locking, in order to protect caches
> > (in 1) the data for a single time zone, in 3) the contents of tzdata.zi).
>
> The idea I had was to go more in the NetBSD / TZDB direction. These
> implementations don't need either locks or lock-free caching algorithms,
> because it's the caller's responsibility to cache.
I don't understand what you mean:
- How can the caller do the caching for something internal to the callee?
I've never seen callbacks being used for that purpose. I've once seen
a calling convention where the caller allocates memory for a cache and
passes it to the callee; but that was for a case where the cache's
lifetime ends when the callee returns.
- The NetBSD code [1][2] does locking in the top-level functions (tzset,
mktime, strftime). I guess that it is because NetBSD uses global variables
(tzname, timezone, daylight, altzone).
For Gnulib, I intend to avoid global variables of this kind — they belong
in data allocated for each time zone — and therefore move the locking to
lower levels. In the frequent case that a timezone is used for the second
time or later, no locking will be needed at all; this will thus be faster
than what NetBSD does.
Bruno
[1] http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/src/lib/libc/time/localtime.c?rev=1.141&only_with_tag=MAIN
[2] http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/src/lib/libc/time/strftime.c?rev=1.55
next prev parent reply other threads:[~2024-02-18 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 17:43 MT-unsafe time modules Bruno Haible
2024-02-09 20:22 ` Bruno Haible
2024-02-10 11:10 ` Bruno Haible
2024-02-11 12:46 ` localtime on native Windows Bruno Haible
2024-02-13 2:02 ` Paul Eggert
2024-02-18 2:38 ` Bruno Haible
2024-02-18 4:50 ` Paul Eggert
2024-02-18 14:38 ` Bruno Haible [this message]
2024-02-18 19:05 ` Paul Eggert
2024-02-11 10:43 ` MT-unsafe time modules Bruno Haible
-- strict thread matches above, loose matches on Subject: below --
2024-02-13 18:25 localtime on native Windows Brian Inglis
2024-02-18 2:14 ` Bruno Haible
2024-02-18 5:32 ` Brian.Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188612.NACDBdzCOe@nimes \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).