From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 219D11F8C6 for ; Sun, 1 Aug 2021 02:11:49 +0000 (UTC) Received: from localhost ([::1]:55450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mA0x9-0005SQ-Rf for normalperson@yhbt.net; Sat, 31 Jul 2021 22:11:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mA0x6-0005RX-8i for bug-gnulib@gnu.org; Sat, 31 Jul 2021 22:11:44 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mA0x4-0000SX-8p for bug-gnulib@gnu.org; Sat, 31 Jul 2021 22:11:43 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 95CF7160083; Sat, 31 Jul 2021 19:11:39 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZvWv-0lRxGxs; Sat, 31 Jul 2021 19:11:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D15861600DB; Sat, 31 Jul 2021 19:11:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5uqDA9i3xCDL; Sat, 31 Jul 2021 19:11:38 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 80AEE160083; Sat, 31 Jul 2021 19:11:38 -0700 (PDT) Subject: Re: "rpl_fprintf" not found if compiled with options "-ggdb -Og" To: Bjarni Ingi Gislason References: <20210728204211.GA397303@rhi.hi.is> <6c8fde67-39e9-2a29-3ea2-d0c59c7c9d8b@cs.ucla.edu> <20210731014311.GA552841@rhi.hi.is> <20210801013300.GA619758@rhi.hi.is> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <514d45d8-b084-ca0c-ce2e-bfea90a3277d@cs.ucla.edu> Date: Sat, 31 Jul 2021 19:11:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210801013300.GA619758@rhi.hi.is> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.124, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 7/31/21 6:33 PM, Bjarni Ingi Gislason wrote: > from ../src/devices/xditview/page.c:7: > ./lib/unistd.h:663:3: error: #error "Please include config.h first." > 663 | #error "Please include config.h first." > | ^~~~~ That's a problem. page.c should include config.h first. This is required of all Autoconf-using code. > In my branch I have added the missing '#include "config.h"' in > ../src/devices/xditview/page.c > and other missing "config.h" lines in other source files. That sounds like the right thing to do, yes. > CPPFLAGS=-D_FORTIFY_SOURCE=2 > > Changing the value from 2 to 0 or 1, eliminates the error. I suggest configuring with the same flags that you build with, and if the flags seriously alter the API or ABI then putting them into CC. Something like this, perhaps. ./configure CC='gcc -D_FORTIFY_SOURCE=2' This sort of thing can be needed if the -D option changes the API or ABI. The idea is that you want to configure with the same flags that you build with.