bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Cc: bug-gnulib@gnu.org
Subject: Re: "rpl_fprintf" not found if compiled with options "-ggdb -Og"
Date: Sat, 31 Jul 2021 19:11:36 -0700	[thread overview]
Message-ID: <514d45d8-b084-ca0c-ce2e-bfea90a3277d@cs.ucla.edu> (raw)
In-Reply-To: <20210801013300.GA619758@rhi.hi.is>

On 7/31/21 6:33 PM, Bjarni Ingi Gislason wrote:
>                   from ../src/devices/xditview/page.c:7:
> ./lib/unistd.h:663:3: error: #error "Please include config.h first."
>    663 |  #error "Please include config.h first."
>        |   ^~~~~

That's a problem. page.c should include config.h first. This is required 
of all Autoconf-using code.

>   In my branch I have added the missing '#include "config.h"' in
> ../src/devices/xditview/page.c
> and other missing "config.h" lines in other source files.

That sounds like the right thing to do, yes.

> CPPFLAGS=-D_FORTIFY_SOURCE=2
> 
>   Changing the value from 2 to 0 or 1, eliminates the error.

I suggest configuring with the same flags that you build with, and if 
the flags seriously alter the API or ABI then putting them into CC. 
Something like this, perhaps.

   ./configure CC='gcc -D_FORTIFY_SOURCE=2'

This sort of thing can be needed if the -D option changes the API or 
ABI. The idea is that you want to configure with the same flags that you 
build with.


      reply	other threads:[~2021-08-01  2:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 20:42 "rpl_fprintf" not found if compiled with options "-ggdb -Og" Bjarni Ingi Gislason
2021-07-28 21:37 ` Paul Eggert
2021-07-31  1:43   ` Bjarni Ingi Gislason
2021-07-31  8:31     ` Paul Eggert
2021-08-01  1:33       ` Bjarni Ingi Gislason
2021-08-01  2:11         ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514d45d8-b084-ca0c-ce2e-bfea90a3277d@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=bjarniig@rhi.hi.is \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).