bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Gisle Vanem <gisle.vanem@gmail.com>
Subject: Re: getaddrinfo tests: fix test failure on MSVC
Date: Wed, 03 Jul 2019 21:50:06 +0200	[thread overview]
Message-ID: <5081906.m4On1JoFHi@omega> (raw)
In-Reply-To: <6b0d4974-66e7-97f6-4548-310b9460a007@gmail.com>

Hi Gisle,

> I found the same problem with test-select-fd.c:
> 
> --- a/tests/test-select-fd.c 2019-01-02 12:05:09
> +++ b/tests/test-select-fd.c 2019-07-03 06:48:11
> @@ -21,6 +21,7 @@
>   #include <stdio.h>
>   #include <stdlib.h>
>   #include <sys/select.h>
> +#include <sockets.h>
> 
>   int
>   main (int argc, char *argv[])
> @@ -44,6 +45,7 @@
>                     struct timeval timeout;
>                     int ret;
> 
> +                  gl_sockets_startup (SOCKETS_1_1);
>                     FD_ZERO (&fds);
>                     FD_SET (fd, &fds);
>                     timeout.tv_sec = 0;

This patch does not fix any of the existing test failures
(test-select, test-select-out.sh) for me.

Note that the select() function used by this file is the
gnulib select, not the <winsock2.h> select.

Bruno



      reply	other threads:[~2019-07-03 19:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 17:38 getaddrinfo tests: fix test failure on MSVC Bruno Haible
2019-07-03  7:08 ` Gisle Vanem
2019-07-03 19:50   ` Bruno Haible [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5081906.m4On1JoFHi@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=gisle.vanem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).